Make some method abstract.

karaoke-dev · Nov 1, 2020 · bb2ad96 · bb2ad96
1 parent 6fb5aff
commit bb2ad96
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/osu.Game.Rulesets.Karaoke/Edit/Singers/Components/DefaultLyricPlacementColumn.cs b/osu.Game.Rulesets.Karaoke/Edit/Singers/Components/DefaultLyricPlacementColumn.cs
@@ -1,6 +1,8 @@
 // Copyright (c) andy840119 <[email protected]>. Licensed under the GPL Licence.
 // See the LICENCE file in the repository root for full licence text.
 
+using osu.Framework.Graphics;
+using osu.Framework.Graphics.Containers;
 using osu.Game.Rulesets.Karaoke.Beatmaps.Metadatas;
 
 namespace osu.Game.Rulesets.Karaoke.Edit.Singers.Components
@@ -11,5 +13,10 @@ public DefaultLyricPlacementColumn()
             : base(new Singer(-1) { Name = "Default" })
         {
         }
+
+        protected override float SingerInfoSize => 200;
+
+        // todo : might display song info?
+        protected override Drawable CreateSingerInfo(Singer singer) => new Container();
     }
 }
diff --git a/osu.Game.Rulesets.Karaoke/Edit/Singers/Components/LyricPlacementColumn.cs b/osu.Game.Rulesets.Karaoke/Edit/Singers/Components/LyricPlacementColumn.cs
@@ -67,9 +67,9 @@ private void load(OverlayColourProvider colourProvider)
             };
         }
 
-        protected virtual float SingerInfoSize => 200;
+        protected abstract float SingerInfoSize { get; }
 
-        protected virtual Drawable CreateSingerInfo(Singer singer) => new Container();
+        protected abstract Drawable CreateSingerInfo(Singer singer) ;
 
         protected class SingerLyricBlueprintContainer : BlueprintContainer
         {

diff --git a/osu.Game.Rulesets.Karaoke/Edit/Singers/Components/SingerLyricPlacementColumn.cs b/osu.Game.Rulesets.Karaoke/Edit/Singers/Components/SingerLyricPlacementColumn.cs
@@ -23,7 +23,7 @@ public SingerLyricPlacementColumn(Singer singer)
         }
 
         // todo : implement singer info here
-        protected override float SingerInfoSize => base.SingerInfoSize - 22;
+        protected override float SingerInfoSize => 178;
 
         protected override Drawable CreateSingerInfo(Singer singer)
         {