Should not deselect the item from the selections after focus out.

Because click the item in the row might cause the focus-out event in the object field textbox.
karaoke-dev · Sep 11, 2022 · 9c0d30c · 9c0d30c
1 parent 3b6feb1
commit 9c0d30c
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 36 deletions.
diff --git a/osu.Game.Rulesets.Karaoke/Edit/Lyrics/Extends/Components/LabelledObjectFieldSwitchButton.cs b/osu.Game.Rulesets.Karaoke/Edit/Lyrics/Extends/Components/LabelledObjectFieldSwitchButton.cs
@@ -59,11 +59,6 @@ protected void TriggerSelect()
             SelectedItems.Add(item);
         }
 
-        protected void TriggerUnselect()
-        {
-            SelectedItems.Remove(item);
-        }
-
         protected abstract bool GetFieldValue(T item);
 
         protected abstract void ApplyValue(T item, bool value);
@@ -73,13 +68,7 @@ protected void TriggerUnselect()
             Selected = selected =>
             {
                 if (selected)
-                {
                     TriggerSelect();
-                }
-                else
-                {
-                    TriggerUnselect();
-                }
             }
         };
 

diff --git a/osu.Game.Rulesets.Karaoke/Edit/Lyrics/Extends/Components/LabelledObjectFieldTextBox.cs b/osu.Game.Rulesets.Karaoke/Edit/Lyrics/Extends/Components/LabelledObjectFieldTextBox.cs
@@ -73,11 +73,6 @@ protected void TriggerSelect()
             SelectedItems.Add(item);
         }
 
-        protected void TriggerUnselect()
-        {
-            SelectedItems.Remove(item);
-        }
-
         protected abstract string GetFieldValue(T item);
 
         protected abstract void ApplyValue(T item, string value);
@@ -92,13 +87,7 @@ protected void TriggerUnselect()
             Selected = selected =>
             {
                 if (selected)
-                {
                     TriggerSelect();
-                }
-                else
-                {
-                    TriggerUnselect();
-                }
             }
         };
 

diff --git a/...Game.Rulesets.Karaoke/Edit/Lyrics/Extends/RubyRomaji/Components/LabelledTextTagTextBox.cs b/...Game.Rulesets.Karaoke/Edit/Lyrics/Extends/RubyRomaji/Components/LabelledTextTagTextBox.cs
@@ -65,14 +65,6 @@ protected LabelledTextTagTextBox(Lyric lyric, T textTag)
                             // trigger selected if hover on delete button.
                             TriggerSelect();
                         }
-                        else
-                        {
-                            // do not clear current selected if typing.
-                            if (Component.HasFocus)
-                                return;
-
-                            TriggerUnselect();
-                        }
                     }
                 }
             });
@@ -95,13 +87,7 @@ protected LabelledTextTagTextBox(Lyric lyric, T textTag)
                     Selected = selected =>
                     {
                         if (selected)
-                        {
                             TriggerSelect();
-                        }
-                        else
-                        {
-                            TriggerUnselect();
-                        }
                     },
                     Action = (indexType, action) =>
                     {