Skip to content

Commit

Permalink
Merge pull request #1287 from andy840119/update-nuget-package
Browse files Browse the repository at this point in the history
Update nuget package.
  • Loading branch information
andy840119 authored Apr 24, 2022
2 parents e6eb7b8 + af76420 commit 950c3d7
Show file tree
Hide file tree
Showing 12 changed files with 28 additions and 30 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ private void load()
lyricCheckerManager = new LyricCheckerManager()
});

Dependencies.Cache(dialogOverlay);
Dependencies.CacheAs<IDialogOverlay>(dialogOverlay);
Dependencies.Cache(lyricCheckerManager);
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ private void load()
lyricCheckManager = new LyricCheckerManager(),
});

Dependencies.Cache(dialogOverlay);
Dependencies.CacheAs<IDialogOverlay>(dialogOverlay);
Dependencies.CacheAs<ILyricsProvider>(lyricsProvider);
Dependencies.Cache(lyricCheckManager);
Dependencies.Cache(new KaraokeRulesetLyricEditorConfigManager());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ private void load()
dialogOverlay = new DialogOverlay(),
});

Dependencies.Cache(dialogOverlay);
Dependencies.CacheAs<IDialogOverlay>(dialogOverlay);
Dependencies.Cache(new EditorClock());
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ private void load()
Dependencies.CacheAs(editorClock);
Dependencies.Cache(beatDivisor);
Dependencies.CacheAs<ILyricsProvider>(lyricsProvider);
Dependencies.Cache(dialogOverlay);
Dependencies.CacheAs<IDialogOverlay>(dialogOverlay);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ private void load()
lyricsProvider = new LyricsProvider()
});

Dependencies.Cache(dialogOverlay);
Dependencies.CacheAs<IDialogOverlay>(dialogOverlay);
Dependencies.CacheAs<ILyricsProvider>(lyricsProvider);
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -134,28 +134,28 @@ public override void ConfirmRollBackFromStep(ILyricImporterStepScreen fromScreen
});
}

public override void OnEntering(IScreen last)
public override void OnEntering(ScreenTransitionEvent e)
{
game.RegisterImportHandler(this);
base.OnEntering(last);
base.OnEntering(e);
}

public override void OnResuming(IScreen last)
public override void OnResuming(ScreenTransitionEvent e)
{
game.RegisterImportHandler(this);
base.OnResuming(last);
base.OnResuming(e);
}

public override void OnSuspending(IScreen next)
public override void OnSuspending(ScreenTransitionEvent e)
{
game.UnregisterImportHandler(this);
base.OnSuspending(next);
base.OnSuspending(e);
}

public override bool OnExiting(IScreen next)
public override bool OnExiting(ScreenExitEvent e)
{
game.UnregisterImportHandler(this);
return base.OnExiting(next);
return base.OnExiting(e);
}

private PopupDialog createFileNotFoundDialog()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public abstract class LyricImporterStepScreen : OsuScreen, ILyricImporterStepScr
protected LyricImporterSubScreenStack ScreenStack { get; private set; }

[Resolved]
protected DialogOverlay DialogOverlay { get; private set; }
protected IDialogOverlay DialogOverlay { get; private set; }

public abstract string ShortTitle { get; }

Expand All @@ -51,31 +51,29 @@ protected LyricImporterStepScreen()
};
}

public override void OnEntering(IScreen last)
public override void OnEntering(ScreenTransitionEvent e)
{
base.OnEntering(e);
this.FadeInFromZero(APPEAR_DURATION, Easing.OutQuint);
this.FadeInFromZero(APPEAR_DURATION, Easing.OutQuint);
this.MoveToX(X_SHIFT).MoveToX(0, X_MOVE_DURATION, Easing.OutQuint);
}

public override bool OnExiting(IScreen next)
public override bool OnExiting(ScreenExitEvent e)
{
base.OnExiting(e);
this.FadeOut(DISAPPEAR_DURATION, Easing.OutQuint);
this.MoveToX(X_SHIFT, X_MOVE_DURATION, Easing.OutQuint);

return false;
}

public override void OnResuming(IScreen last)
public override void OnResuming(ScreenTransitionEvent e)
{
this.Delay(RESUME_TRANSITION_DELAY).FadeIn(APPEAR_DURATION, Easing.OutQuint);
this.MoveToX(0, X_MOVE_DURATION, Easing.OutQuint);
base.OnResuming(e);
this.FadeIn(APPEAR_DURATION, Easing.OutQuint);
}

public override void OnSuspending(IScreen next)
public override void OnSuspending(ScreenTransitionEvent e)
{
base.OnSuspending(e);
this.FadeOut(DISAPPEAR_DURATION, Easing.OutQuint);
this.MoveToX(-X_SHIFT, X_MOVE_DURATION, Easing.OutQuint);
}

public abstract void Complete();
Expand Down
2 changes: 1 addition & 1 deletion osu.Game.Rulesets.Karaoke/Edit/Lyrics/Rows/EditLyricRow.cs
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public class InfoControl : Container, IHasContextMenu
private readonly IBindable<TimeTagEditMode> bindableTimeTagEditMode = new Bindable<TimeTagEditMode>();

[Resolved(canBeNull: true)]
private DialogOverlay dialogOverlay { get; set; }
private IDialogOverlay dialogOverlay { get; set; }

[Resolved]
private ILyricsChangeHandler lyricsChangeHandler { get; set; }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ internal class DrawableSingerInfo : CompositeDrawable, IHasCustomTooltip<Singer>
private ISingersChangeHandler singersChangeHandler { get; set; }

[Resolved]
private DialogOverlay dialogOverlay { get; set; }
private IDialogOverlay dialogOverlay { get; set; }

private readonly IBindable<int> bindableOrder = new Bindable<int>();
private readonly IBindable<float> bindableHue = new Bindable<float>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public class RemoveLanguageButton : IconButton
private ILanguagesChangeHandler languagesChangeHandler { get; set; }

[Resolved]
private DialogOverlay dialogOverlay { get; set; }
private IDialogOverlay dialogOverlay { get; set; }

[Resolved]
private IBindable<CultureInfo> currentLanguage { get; set; }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ public class DeleteButton : CompositeDrawable
public Func<Vector2, bool> IsTextBoxHovered;

[Resolved(CanBeNull = true)]
private DialogOverlay dialogOverlay { get; set; }
private IDialogOverlay dialogOverlay { get; set; }

[Resolved(CanBeNull = true)]
private LayoutManager layoutManager { get; set; }
Expand Down
2 changes: 1 addition & 1 deletion osu.Game.Rulesets.Karaoke/osu.Game.Rulesets.Karaoke.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<PackageReference Include="Octokit" Version="0.50.0" />
<PackageReference Include="osu.Framework.KaraokeFont" Version="2022.424.0" />
<PackageReference Include="osu.Framework.Microphone" Version="2022.327.0" />
<PackageReference Include="ppy.osu.Game" Version="2022.418.0" />
<PackageReference Include="ppy.osu.Game" Version="2022.424.0" />
<PackageReference Include="LyricMaker" Version="1.1.1" />
<PackageReference Include="NicoKaraParser" Version="1.1.0" />
<PackageReference Include="SixLabors.Fonts" Version="1.0.0-beta15" />
Expand Down

0 comments on commit 950c3d7

Please sign in to comment.