should just return null because this function will be called now.

karaoke-dev · Mar 25, 2022 · 8cdec80 · 8cdec80
1 parent e7aff16
commit 8cdec80
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 10 deletions.
diff --git a/osu.Game.Rulesets.Karaoke.Tests/Resources/TestResources.cs b/osu.Game.Rulesets.Karaoke.Tests/Resources/TestResources.cs
@@ -1,7 +1,6 @@
 // Copyright (c) andy840119 <[email protected]>. Licensed under the GPL Licence.
 // See the LICENCE file in the repository root for full licence text.
 
-using System;
 using System.IO;
 using NUnit.Framework;
 using osu.Framework.Audio;
@@ -52,10 +51,7 @@ public TestStorageResourceProvider(string skinName)
                 Files = Resources = new NamespacedResourceStore<byte[]>(new DllResourceStore(GetType().Assembly), $"Resources/{skinName}");
             }
 
-            public IResourceStore<TextureUpload> CreateTextureLoaderStore(IResourceStore<byte[]> underlyingStore)
-            {
-                throw new NotImplementedException();
-            }
+            public IResourceStore<TextureUpload> CreateTextureLoaderStore(IResourceStore<byte[]> underlyingStore) => null;
 
             public AudioManager AudioManager => null;
             public IResourceStore<byte[]> Files { get; }

diff --git a/osu.Game.Rulesets.Karaoke/Skinning/Legacy/KaraokeLegacySkinTransformer.cs b/osu.Game.Rulesets.Karaoke/Skinning/Legacy/KaraokeLegacySkinTransformer.cs
@@ -96,7 +96,7 @@ public override IBindable<TValue> GetConfig<TLookup, TValue>(TLookup lookup)
         private class TempLegacySkin : LegacySkin
         {
             public TempLegacySkin(SkinInfo skin)
-                : base(skin, null, null, default(string))
+                : base(skin, null, null)
             {
             }
         }
@@ -109,10 +109,7 @@ public InternalSkinStorageResourceProvider(string skinName)
                 Files = Resources = new NamespacedResourceStore<byte[]>(store, $"Skin/{skinName}");
             }
 
-            public IResourceStore<TextureUpload> CreateTextureLoaderStore(IResourceStore<byte[]> underlyingStore)
-            {
-                throw new NotImplementedException();
-            }
+            public IResourceStore<TextureUpload> CreateTextureLoaderStore(IResourceStore<byte[]> underlyingStore) => null;
 
             public AudioManager AudioManager => null;
             public IResourceStore<byte[]> Files { get; }