Merge pull request #1807 from andy840119/implement-base-generator-test

Refactor the generate config method.
karaoke-dev · Dec 22, 2022 · 8b86d64 · 8b86d64
2 parents b4b3893 + 067b920
commit 8b86d64
Show file tree

Hide file tree

Showing 14 changed files with 77 additions and 95 deletions.
diff --git a/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/BaseGeneratorTest.cs b/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/BaseGeneratorTest.cs
@@ -0,0 +1,24 @@
+// Copyright (c) andy840119 <[email protected]>. Licensed under the GPL Licence.
+// See the LICENCE file in the repository root for full licence text.
+
+using System;
+using osu.Game.Rulesets.Karaoke.Edit.Generator;
+
+namespace osu.Game.Rulesets.Karaoke.Tests.Editor.Generator;
+
+public class BaseGeneratorTest<TConfig> where TConfig : IHasConfig<TConfig>, new()
+{
+    protected static TConfig GeneratorConfig(Action<TConfig>? action = null)
+    {
+        var config = new TConfig();
+        action?.Invoke(config);
+        return config;
+    }
+
+    protected static TConfig GeneratorDefaultConfig(Action<TConfig>? action = null)
+    {
+        var config = new TConfig().CreateDefaultConfig();
+        action?.Invoke(config);
+        return config;
+    }
+}
diff --git a/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Beatmaps/BaseBeatmapDetectorTest.cs b/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Beatmaps/BaseBeatmapDetectorTest.cs
@@ -4,32 +4,15 @@
 using System;
 using NUnit.Framework;
 using osu.Game.Rulesets.Karaoke.Beatmaps;
+using osu.Game.Rulesets.Karaoke.Edit.Generator;
 using osu.Game.Rulesets.Karaoke.Edit.Generator.Beatmaps;
 
 namespace osu.Game.Rulesets.Karaoke.Tests.Editor.Generator.Beatmaps
 {
     public abstract class BaseBeatmapDetectorTest<TDetector, TObject, TConfig>
-        where TDetector : class, IBeatmapPropertyDetector<TObject> where TConfig : new()
+        : BaseGeneratorTest<TConfig>
+        where TDetector : class, IBeatmapPropertyDetector<TObject> where TConfig : IHasConfig<TConfig>, new()
     {
-        protected static TConfig GeneratorConfig(params string?[] properties)
-        {
-            var config = new TConfig();
-
-            foreach (string? propertyName in properties)
-            {
-                if (propertyName == null)
-                    continue;
-
-                var theMethod = config.GetType().GetProperty(propertyName);
-                if (theMethod == null)
-                    throw new MissingMethodException("Config is not exist.");
-
-                theMethod.SetValue(config, true);
-            }
-
-            return config;
-        }
-
         protected static TDetector GenerateDetector(TConfig config)
         {
             if (Activator.CreateInstance(typeof(TDetector), config) is not TDetector detector)

diff --git a/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Beatmaps/BaseBeatmapGeneratorTest.cs b/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Beatmaps/BaseBeatmapGeneratorTest.cs
@@ -10,15 +10,9 @@
 namespace osu.Game.Rulesets.Karaoke.Tests.Editor.Generator.Beatmaps
 {
     public abstract class BaseBeatmapGeneratorTest<TGenerator, TObject, TConfig>
+        : BaseGeneratorTest<TConfig>
         where TGenerator : class, IBeatmapPropertyGenerator<TObject> where TConfig : IHasConfig<TConfig>, new()
     {
-        protected static TConfig GeneratorConfig(Action<TConfig>? action = null)
-        {
-            var config = new TConfig().CreateDefaultConfig();
-            action?.Invoke(config);
-            return config;
-        }
-
         protected static TGenerator GenerateGenerator(TConfig config)
         {
             if (Activator.CreateInstance(typeof(TGenerator), config) is not TGenerator generator)

diff --git a/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Beatmaps/Pages/PageGeneratorTest.cs b/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Beatmaps/Pages/PageGeneratorTest.cs
@@ -26,7 +26,7 @@ public class PageGeneratorTest : BaseBeatmapGeneratorTest<PageGenerator, Page[],
     [TestCase(new string[] { }, false)]
     public void TestCanGenerate(string[] lyrics, bool canGenerate)
     {
-        var config = GeneratorConfig();
+        var config = GeneratorDefaultConfig();
         var beatmap = new KaraokeBeatmap
         {
             HitObjects = TestCaseTagHelper.ParseLyrics(lyrics).OfType<KaraokeHitObject>().ToList(),
@@ -38,7 +38,7 @@ public void TestCanGenerate(string[] lyrics, bool canGenerate)
     [Test]
     public void TestGenerateWithZeroLyric()
     {
-        var config = GeneratorConfig();
+        var config = GeneratorDefaultConfig();
         var beatmap = new KaraokeBeatmap
         {
             HitObjects = new List<KaraokeHitObject>()
@@ -53,7 +53,7 @@ public void TestGenerateWithZeroLyric()
     [TestCase("[1000,23000]:karaoke", new[] { 1000, 1000 + max_interval, 1000 + max_interval * 2, 23000 })]
     public void TestGenerateWithSingleLyric(string lyric, double[] expectedTimes)
     {
-        var config = GeneratorConfig();
+        var config = GeneratorDefaultConfig();
         var beatmap = new KaraokeBeatmap
         {
             HitObjects = new List<KaraokeHitObject>
@@ -77,7 +77,7 @@ public void TestGenerateWithSingleLyric(string lyric, double[] expectedTimes)
     [TestCase("[1000,23000]:karaoke", "[3000,4000]:karaoke", new[] { 1000, 1000 + max_interval, 1000 + max_interval * 2, 23000 })] // should ignore second lyric.
     public void TestGenerateWithTwoLyrics(string firstLyric, string secondLyric, double[] expectedTimes)
     {
-        var config = GeneratorConfig();
+        var config = GeneratorDefaultConfig();
         var beatmap = new KaraokeBeatmap
         {
             HitObjects = new List<KaraokeHitObject>

diff --git a/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/BaseLyricDetectorTest.cs b/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/BaseLyricDetectorTest.cs
@@ -3,33 +3,16 @@
 
 using System;
 using NUnit.Framework;
+using osu.Game.Rulesets.Karaoke.Edit.Generator;
 using osu.Game.Rulesets.Karaoke.Edit.Generator.Lyrics;
 using osu.Game.Rulesets.Karaoke.Objects;
 
 namespace osu.Game.Rulesets.Karaoke.Tests.Editor.Generator.Lyrics
 {
     public abstract class BaseLyricDetectorTest<TDetector, TObject, TConfig>
-        where TDetector : class, ILyricPropertyDetector<TObject> where TConfig : new()
+        : BaseGeneratorTest<TConfig>
+        where TDetector : class, ILyricPropertyDetector<TObject> where TConfig : IHasConfig<TConfig>, new()
     {
-        protected static TConfig GeneratorConfig(params string?[] properties)
-        {
-            var config = new TConfig();
-
-            foreach (string? propertyName in properties)
-            {
-                if (propertyName == null)
-                    continue;
-
-                var theMethod = config.GetType().GetProperty(propertyName);
-                if (theMethod == null)
-                    throw new MissingMethodException("Config is not exist.");
-
-                theMethod.SetValue(config, true);
-            }
-
-            return config;
-        }
-
         protected static TDetector GenerateDetector(TConfig config)
         {
             if (Activator.CreateInstance(typeof(TDetector), config) is not TDetector detector)

diff --git a/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/BaseLyricGeneratorTest.cs b/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/BaseLyricGeneratorTest.cs
@@ -3,33 +3,16 @@
 
 using System;
 using NUnit.Framework;
+using osu.Game.Rulesets.Karaoke.Edit.Generator;
 using osu.Game.Rulesets.Karaoke.Edit.Generator.Lyrics;
 using osu.Game.Rulesets.Karaoke.Objects;
 
 namespace osu.Game.Rulesets.Karaoke.Tests.Editor.Generator.Lyrics
 {
     public abstract class BaseLyricGeneratorTest<TGenerator, TObject, TConfig>
-        where TGenerator : class, ILyricPropertyGenerator<TObject> where TConfig : new()
+        : BaseGeneratorTest<TConfig>
+        where TGenerator : class, ILyricPropertyGenerator<TObject> where TConfig : IHasConfig<TConfig>, new()
     {
-        protected static TConfig GeneratorConfig(params string?[] properties)
-        {
-            var config = new TConfig();
-
-            foreach (string? propertyName in properties)
-            {
-                if (propertyName == null)
-                    continue;
-
-                var theMethod = config.GetType().GetProperty(propertyName);
-                if (theMethod == null)
-                    throw new MissingMethodException("Config is not exist.");
-
-                theMethod.SetValue(config, true);
-            }
-
-            return config;
-        }
-
         protected static TGenerator GenerateGenerator(TConfig config)
         {
             if (Activator.CreateInstance(typeof(TGenerator), config) is not TGenerator generator)

diff --git a/...lesets.Karaoke.Tests/Editor/Generator/Lyrics/ReferenceLyric/ReferenceLyricDetectorTest.cs b/...lesets.Karaoke.Tests/Editor/Generator/Lyrics/ReferenceLyric/ReferenceLyricDetectorTest.cs
@@ -59,7 +59,7 @@ public void TestCanDetectWithIgnorePrefixAndPostfixSymbol(string lyricText, stri
                 },
                 detectedLyric
             };
-            var config = GeneratorConfig("IgnorePrefixAndPostfixSymbol");
+            var config = GeneratorConfig(x => x.IgnorePrefixAndPostfixSymbol = true);
             CheckCanDetect(lyrics, detectedLyric, canDetect, config);
         }
 

diff --git a/...e.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/RomajiTags/BaseRomajiTagGeneratorTest.cs b/...e.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/RomajiTags/BaseRomajiTagGeneratorTest.cs
@@ -1,6 +1,7 @@
 // Copyright (c) andy840119 <[email protected]>. Licensed under the GPL Licence.
 // See the LICENCE file in the repository root for full licence text.
 
+using osu.Game.Rulesets.Karaoke.Edit.Generator;
 using osu.Game.Rulesets.Karaoke.Edit.Generator.Lyrics.RomajiTags;
 using osu.Game.Rulesets.Karaoke.Objects;
 using osu.Game.Rulesets.Karaoke.Tests.Asserts;
@@ -9,7 +10,7 @@
 namespace osu.Game.Rulesets.Karaoke.Tests.Editor.Generator.Lyrics.RomajiTags
 {
     public abstract class BaseRomajiTagGeneratorTest<TRomajiTagGenerator, TConfig> : BaseLyricGeneratorTest<TRomajiTagGenerator, RomajiTag[], TConfig>
-        where TRomajiTagGenerator : RomajiTagGenerator<TConfig> where TConfig : RomajiTagGeneratorConfig, new()
+        where TRomajiTagGenerator : RomajiTagGenerator<TConfig> where TConfig : RomajiTagGeneratorConfig, IHasConfig<TConfig>, new()
     {
         protected static void CheckCanGenerate(string text, bool canGenerate, TConfig config)
         {

diff --git a/....Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/RomajiTags/Ja/JaRomajiTagGeneratorTest.cs b/....Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/RomajiTags/Ja/JaRomajiTagGeneratorTest.cs
@@ -31,7 +31,7 @@ public void TestGenerate(string text, string[] expectedRomajies)
         [TestCase("はなび", new[] { "[0,3]:HANABI" })]
         public void TestGenerateWithUppercase(string text, string[] expectedRomajies)
         {
-            var config = GeneratorConfig(nameof(JaRomajiTagGeneratorConfig.Uppercase));
+            var config = GeneratorConfig(x => x.Uppercase = true);
             CheckGenerateResult(text, expectedRomajies, config);
         }
     }

diff --git a/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/RubyTags/BaseRubyTagGeneratorTest.cs b/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/RubyTags/BaseRubyTagGeneratorTest.cs
@@ -1,6 +1,7 @@
 // Copyright (c) andy840119 <[email protected]>. Licensed under the GPL Licence.
 // See the LICENCE file in the repository root for full licence text.
 
+using osu.Game.Rulesets.Karaoke.Edit.Generator;
 using osu.Game.Rulesets.Karaoke.Edit.Generator.Lyrics.RubyTags;
 using osu.Game.Rulesets.Karaoke.Objects;
 using osu.Game.Rulesets.Karaoke.Tests.Asserts;
@@ -9,7 +10,7 @@
 namespace osu.Game.Rulesets.Karaoke.Tests.Editor.Generator.Lyrics.RubyTags
 {
     public abstract class BaseRubyTagGeneratorTest<TRubyTagGenerator, TConfig> : BaseLyricGeneratorTest<TRubyTagGenerator, RubyTag[], TConfig>
-        where TRubyTagGenerator : RubyTagGenerator<TConfig> where TConfig : RubyTagGeneratorConfig, new()
+        where TRubyTagGenerator : RubyTagGenerator<TConfig> where TConfig : RubyTagGeneratorConfig, IHasConfig<TConfig>, new()
     {
         protected static void CheckCanGenerate(string text, bool canGenerate, TConfig config)
         {

diff --git a/...Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/RubyTags/Ja/JaRubyTagGeneratorTest.cs b/...Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/RubyTags/Ja/JaRubyTagGeneratorTest.cs
@@ -31,15 +31,15 @@ public void TestGenerate(string text, string[] expectedRubies)
         [TestCase("ハナビ", new string[] { })]
         public void TestGenerateWithRubyAsKatakana(string text, string[] expectedRubies)
         {
-            var config = GeneratorConfig(nameof(JaRubyTagGeneratorConfig.RubyAsKatakana));
+            var config = GeneratorConfig(x => x.RubyAsKatakana = true);
             CheckGenerateResult(text, expectedRubies, config);
         }
 
         [TestCase("はなび", new[] { "[0,2]:はな", "[2,3]:び" })]
         [TestCase("ハナビ", new[] { "[0,3]:はなび" })]
         public void TestGenerateWithEnableDuplicatedRuby(string text, string[] expectedRubies)
         {
-            var config = GeneratorConfig(nameof(JaRubyTagGeneratorConfig.EnableDuplicatedRuby));
+            var config = GeneratorConfig(x => x.EnableDuplicatedRuby = true);
             CheckGenerateResult(text, expectedRubies, config);
         }
     }

diff --git a/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/TimeTags/BaseTimeTagGeneratorTest.cs b/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/TimeTags/BaseTimeTagGeneratorTest.cs
@@ -1,6 +1,7 @@
 // Copyright (c) andy840119 <[email protected]>. Licensed under the GPL Licence.
 // See the LICENCE file in the repository root for full licence text.
 
+using osu.Game.Rulesets.Karaoke.Edit.Generator;
 using osu.Game.Rulesets.Karaoke.Edit.Generator.Lyrics.TimeTags;
 using osu.Game.Rulesets.Karaoke.Objects;
 using osu.Game.Rulesets.Karaoke.Tests.Asserts;
@@ -9,7 +10,7 @@
 namespace osu.Game.Rulesets.Karaoke.Tests.Editor.Generator.Lyrics.TimeTags
 {
     public abstract class BaseTimeTagGeneratorTest<TTimeTagGenerator, TConfig> : BaseLyricGeneratorTest<TTimeTagGenerator, TimeTag[], TConfig>
-        where TTimeTagGenerator : TimeTagGenerator<TConfig> where TConfig : TimeTagGeneratorConfig, new()
+        where TTimeTagGenerator : TimeTagGenerator<TConfig> where TConfig : TimeTagGeneratorConfig, IHasConfig<TConfig>, new()
     {
         protected static void CheckCanGenerate(string text, bool canGenerate, TConfig config)
         {

diff --git a/...Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/TimeTags/Ja/JaTimeTagGeneratorTest.cs b/...Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/TimeTags/Ja/JaTimeTagGeneratorTest.cs
@@ -25,32 +25,35 @@ public void TestCanGenerate(string text, bool canGenerate)
         [TestCase("か", new[] { "[0,start]:", "[0,end]:" }, true)]
         public void TestGenerateWithCheckLineEndKeyUp(string lyric, string[] expectedTimeTags, bool applyConfig)
         {
-            var config = GeneratorConfig(applyConfig ? nameof(JaTimeTagGeneratorConfig.CheckLineEndKeyUp) : null);
+            var config = GeneratorConfig(x => x.CheckLineEndKeyUp = applyConfig);
             CheckGenerateResult(lyric, expectedTimeTags, config);
         }
 
         [TestCase(" ", new string[] { }, false)]
         [TestCase(" ", new[] { "[0,start]:" }, true)]
         public void TestGenerateWithCheckBlankLine(string lyric, string[] expectedTimeTags, bool applyConfig)
         {
-            var config = GeneratorConfig(applyConfig ? nameof(JaTimeTagGeneratorConfig.CheckBlankLine) : null);
+            var config = GeneratorConfig(x => x.CheckBlankLine = applyConfig);
             CheckGenerateResult(lyric, expectedTimeTags, config);
         }
 
         [TestCase("か     ", new[] { "[0,start]:", "[1,start]:", "[2,start]:", "[3,start]:", "[4,start]:", "[5,start]:" }, false)]
         [TestCase("か     ", new[] { "[0,start]:", "[1,start]:" }, true)]
         public void TestGenerateWithCheckWhiteSpace(string lyric, string[] expectedTimeTags, bool applyConfig)
         {
-            var config = GeneratorConfig(applyConfig ? nameof(JaTimeTagGeneratorConfig.CheckWhiteSpace) : null);
+            var config = GeneratorConfig(x => x.CheckWhiteSpace = applyConfig);
             CheckGenerateResult(lyric, expectedTimeTags, config);
         }
 
         [TestCase("か ", new[] { "[0,start]:", "[1,start]:" }, false)]
         [TestCase("か ", new[] { "[0,start]:", "[0,end]:" }, true)]
         public void TestGenerateWithCheckWhiteSpaceKeyUp(string lyric, string[] expectedTimeTags, bool applyConfig)
         {
-            var config = GeneratorConfig(nameof(JaTimeTagGeneratorConfig.CheckWhiteSpace),
-                applyConfig ? nameof(JaTimeTagGeneratorConfig.CheckWhiteSpaceKeyUp) : null);
+            var config = GeneratorConfig(x =>
+            {
+                x.CheckWhiteSpace = true;
+                x.CheckWhiteSpaceKeyUp = applyConfig;
+            });
             CheckGenerateResult(lyric, expectedTimeTags, config);
         }
 
@@ -62,9 +65,12 @@ public void TestGenerateWithCheckWhiteSpaceKeyUp(string lyric, string[] expected
         [TestCase("Ａ　Ｂ　Ｃ", new[] { "[0,start]:", "[0,end]:", "[2,start]:", "[2,end]:", "[4,start]:" }, true, true)]
         public void TestGenerateWithCheckWhiteSpaceAlphabet(string lyric, string[] expectedTimeTags, bool applyConfig, bool keyUp)
         {
-            var config = GeneratorConfig(nameof(JaTimeTagGeneratorConfig.CheckWhiteSpace),
-                applyConfig ? nameof(JaTimeTagGeneratorConfig.CheckWhiteSpaceAlphabet) : null,
-                keyUp ? nameof(JaTimeTagGeneratorConfig.CheckWhiteSpaceKeyUp) : null);
+            var config = GeneratorConfig(x =>
+            {
+                x.CheckWhiteSpace = true;
+                x.CheckWhiteSpaceAlphabet = applyConfig;
+                x.CheckWhiteSpaceKeyUp = keyUp;
+            });
             CheckGenerateResult(lyric, expectedTimeTags, config);
         }
 
@@ -76,9 +82,12 @@ public void TestGenerateWithCheckWhiteSpaceAlphabet(string lyric, string[] expec
         [TestCase("０　１　２", new[] { "[0,start]:", "[0,end]:", "[2,start]:", "[2,end]:", "[4,start]:" }, true, true)]
         public void TestGenerateWithCheckWhiteSpaceDigit(string lyric, string[] expectedTimeTags, bool applyConfig, bool keyUp)
         {
-            var config = GeneratorConfig(nameof(JaTimeTagGeneratorConfig.CheckWhiteSpace),
-                applyConfig ? nameof(JaTimeTagGeneratorConfig.CheckWhiteSpaceDigit) : null,
-                keyUp ? nameof(JaTimeTagGeneratorConfig.CheckWhiteSpaceKeyUp) : null);
+            var config = GeneratorConfig(x =>
+            {
+                x.CheckWhiteSpace = true;
+                x.CheckWhiteSpaceDigit = applyConfig;
+                x.CheckWhiteSpaceKeyUp = keyUp;
+            });
             CheckGenerateResult(lyric, expectedTimeTags, config);
         }
 
@@ -87,25 +96,28 @@ public void TestGenerateWithCheckWhiteSpaceDigit(string lyric, string[] expected
         [TestCase("!　!　!", new[] { "[0,start]:", "[0,end]:", "[2,start]:", "[2,end]:", "[4,start]:" }, true, true)]
         public void TestGenerateWitCheckWhiteSpaceAsciiSymbol(string lyric, string[] expectedTimeTags, bool applyConfig, bool keyUp)
         {
-            var config = GeneratorConfig(nameof(JaTimeTagGeneratorConfig.CheckWhiteSpace),
-                applyConfig ? nameof(JaTimeTagGeneratorConfig.CheckWhiteSpaceAsciiSymbol) : null,
-                keyUp ? nameof(JaTimeTagGeneratorConfig.CheckWhiteSpaceKeyUp) : null);
+            var config = GeneratorConfig(x =>
+            {
+                x.CheckWhiteSpace = true;
+                x.CheckWhiteSpaceAsciiSymbol = applyConfig;
+                x.CheckWhiteSpaceKeyUp = keyUp;
+            });
             CheckGenerateResult(lyric, expectedTimeTags, config);
         }
 
         [TestCase("がんばって", new[] { "[0,start]:", "[2,start]:", "[4,start]:" }, false)]
         [TestCase("がんばって", new[] { "[0,start]:", "[1,start]:", "[2,start]:", "[4,start]:" }, true)]
         public void TestGenerateWithCheckWhiteCheckん(string lyric, string[] expectedTimeTags, bool applyConfig)
         {
-            var config = GeneratorConfig(applyConfig ? nameof(JaTimeTagGeneratorConfig.Checkん) : null);
+            var config = GeneratorConfig(x => x.Checkん = applyConfig);
             CheckGenerateResult(lyric, expectedTimeTags, config);
         }
 
         [TestCase("買って", new[] { "[0,start]:", "[2,start]:" }, false)]
         [TestCase("買って", new[] { "[0,start]:", "[1,start]:", "[2,start]:" }, true)]
         public void TestGenerateWithCheckっ(string lyric, string[] expectedTimeTags, bool applyConfig)
         {
-            var config = GeneratorConfig(applyConfig ? nameof(JaTimeTagGeneratorConfig.Checkっ) : null);
+            var config = GeneratorConfig(x => x.Checkっ = applyConfig);
             CheckGenerateResult(lyric, expectedTimeTags, config);
         }
 

diff --git a/...Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/TimeTags/Zh/ZhTimeTagGeneratorTest.cs b/...Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/TimeTags/Zh/ZhTimeTagGeneratorTest.cs
@@ -25,7 +25,7 @@ public void TestCanGenerate(string text, bool canGenerate)
         [TestCase("拉~拉~拉~", new[] { "[0,start]:", "[2,start]:", "[4,start]:", "[5,end]:" })]
         public void TestGenerateWithCheckLineEndKeyUp(string lyric, string[] expectedTimeTags)
         {
-            var config = GeneratorConfig(nameof(ZhTimeTagGeneratorConfig.CheckLineEndKeyUp));
+            var config = GeneratorConfig(x => x.CheckLineEndKeyUp = true);
             CheckGenerateResult(lyric, expectedTimeTags, config);
         }
     }