Can use string.Empty() instead.

karaoke-dev · Jul 13, 2023 · 4c516ac · 4c516ac
1 parent 877db56
commit 4c516ac
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/...me.Rulesets.Karaoke.Tests/Editor/ChangeHandlers/Lyrics/LyricTranslateChangeHandlerTest.cs b/...me.Rulesets.Karaoke.Tests/Editor/ChangeHandlers/Lyrics/LyricTranslateChangeHandlerTest.cs
@@ -81,7 +81,7 @@ public void TestUpdateTranslateWithNullText()
             }
         });
 
-        TriggerHandlerChanged(c => c.UpdateTranslate(new CultureInfo(17), ""));
+        TriggerHandlerChanged(c => c.UpdateTranslate(new CultureInfo(17), string.Empty));
 
         AssertSelectedHitObject(h =>
         {

diff --git a/osu.Game.Rulesets.Karaoke/Screens/Edit/Beatmaps/Components/UserInterfaceV2/LyricSelector.cs b/osu.Game.Rulesets.Karaoke/Screens/Edit/Beatmaps/Components/UserInterfaceV2/LyricSelector.cs
@@ -117,7 +117,7 @@ public DrawableLyricListItem(Lyric? item)
 
             public override IEnumerable<LocalisableString> FilterTerms => new[]
             {
-                new LocalisableString(Model?.Text ?? ""),
+                new LocalisableString(Model?.Text ?? string.Empty),
             };
 
             protected override void CreateDisplayContent(OsuTextFlowContainer textFlowContainer, Lyric? model)

diff --git a/osu.Game.Rulesets.Karaoke/Screens/Edit/IssueSection.cs b/osu.Game.Rulesets.Karaoke/Screens/Edit/IssueSection.cs
@@ -234,7 +234,7 @@ private LocalisableString getTextByIssueType(IssueType issueType) =>
             };
 
         private Colour4 getColourByIssueType(IssueType issueType) =>
-            new IssueTemplate(new EmptyCheck(), issueType, "").Colour;
+            new IssueTemplate(new EmptyCheck(), issueType, string.Empty).Colour;
 
         [BackgroundDependencyLoader]
         private void load(OverlayColourProvider colourProvider)
-Original file line number
+Diff line change
@@ Expand Up / @@ -81,7 +81,7 @@ public void TestUpdateTranslateWithNullText() @@
                 }
             });
-            TriggerHandlerChanged(c => c.UpdateTranslate(new CultureInfo(17), ""));
+            TriggerHandlerChanged(c => c.UpdateTranslate(new CultureInfo(17), string.Empty));
             AssertSelectedHitObject(h =>
             {
@@ Expand Down @@