Legacy skin should inherit the default skin transformer for able to i…

…nherit the base logic.
karaoke-dev · Apr 29, 2023 · 431c8a0 · 431c8a0
1 parent e43b2d0
commit 431c8a0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/osu.Game.Rulesets.Karaoke/Skinning/Legacy/KaraokeClassicSkinTransformer.cs b/osu.Game.Rulesets.Karaoke/Skinning/Legacy/KaraokeClassicSkinTransformer.cs
@@ -8,8 +8,8 @@ namespace osu.Game.Rulesets.Karaoke.Skinning.Legacy
 {
     public class KaraokeClassicSkinTransformer : KaraokeLegacySkinTransformer
     {
-        public KaraokeClassicSkinTransformer(ISkin source, IBeatmap beatmap)
-            : base(source, beatmap)
+        public KaraokeClassicSkinTransformer(ISkin skin, IBeatmap beatmap)
+            : base(skin, beatmap)
         {
         }
     }

diff --git a/osu.Game.Rulesets.Karaoke/Skinning/Legacy/KaraokeLegacySkinTransformer.cs b/osu.Game.Rulesets.Karaoke/Skinning/Legacy/KaraokeLegacySkinTransformer.cs
@@ -6,18 +6,24 @@
 using osu.Framework.Bindables;
 using osu.Framework.Graphics;
 using osu.Game.Beatmaps;
+using osu.Game.Rulesets.Karaoke.Skinning.Default;
 using osu.Game.Rulesets.Scoring;
 using osu.Game.Skinning;
 
 namespace osu.Game.Rulesets.Karaoke.Skinning.Legacy
 {
-    public class KaraokeLegacySkinTransformer : LegacySkinTransformer
+    /// <summary>
+    /// Not inherit the <see cref="LegacySkinTransformer"/> because:
+    /// 1. Karaoke ruleset does not have the legacy skin.
+    /// 2. There's not much logic in the <see cref="LegacySkinTransformer"/>
+    /// </summary>
+    public class KaraokeLegacySkinTransformer : KaraokeDefaultSkinTransformer
     {
         private readonly Lazy<bool> isLegacySkin;
         private readonly KaraokeBeatmapSkin karaokeSkin;
 
-        public KaraokeLegacySkinTransformer(ISkin source, IBeatmap beatmap)
-            : base(source)
+        public KaraokeLegacySkinTransformer(ISkin skin, IBeatmap beatmap)
+            : base(skin, beatmap)
         {
             // we should get config by default karaoke skin.
             // if has resource or texture, then try to get from legacy skin.