Skip to content

Commit

Permalink
Merge pull request #67 from andy840119/refactor-the-line-test-case
Browse files Browse the repository at this point in the history 
Refactor the line test case.
  • Loading branch information
@andy840119
andy840119 authored Jul 25, 2024
2 parents 7158b12 + 639be9d commit 736a814
Show file tree
Hide file tree
Showing 13 changed files with 401 additions and 105 deletions.
127 changes: 102 additions & 25 deletions LrcParser.Tests/Parser/Kar/Lines/KarLyricParserTest.cs
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Copyright (c) karaoke.dev <[email protected]>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text.

using System.Collections.Generic;
using LrcParser.Parser.Kar.Lines;
using LrcParser.Parser.Kar.Metadata;
using LrcParser.Tests.Helper;
Expand All @@ -22,39 +23,115 @@ public void TestCanDecode(string text, bool expected)
Assert.That(actual, Is.EqualTo(expected));
}

[TestCase("[00:17:97]帰[00:18:37]り[00:18:55]道[00:18:94]は[00:19:22]", "帰り道は", new[] { "[0,start]:17970", "[1,start]:18370", "[2,start]:18550", "[3,start]:18940", "[3,end]:19220" })]
[TestCase("帰[00:18:37]り[00:18:55]道[00:18:94]は[00:19:22]", "帰り道は", new[] { "[1,start]:18370", "[2,start]:18550", "[3,start]:18940", "[3,end]:19220" })]
[TestCase("[00:17:97]帰[00:18:37]り[00:18:55]道[00:18:94]は", "帰り道は", new[] { "[0,start]:17970", "[1,start]:18370", "[2,start]:18550", "[3,start]:18940" })]
[TestCase("帰り道は", "帰り道は", new string[] { })]
[TestCase("", "", new string[] { })]
[TestCase(null, "", new string[] { })]
public void TestDecode(string lyric, string text, string[] timeTags)
[TestCaseSource(nameof(testDecodeSource))]
public void TestDecode(string lyric, KarLyric expected)
{
var expected = new KarLyric
{
Text = text,
TimeTags = TestCaseTagHelper.ParseTimeTags(timeTags),
};
var actual = Decode(lyric);

Assert.That(actual.Text, Is.EqualTo(expected.Text));
Assert.That(actual.TimeTags, Is.EqualTo(expected.TimeTags));
Assert.That(actual, Is.EqualTo(expected));
}

[TestCase("帰り道は", new[] { "[0,start]:17970", "[1,start]:18370", "[2,start]:18550", "[3,start]:18940", "[3,end]:19220" }, "[00:17.97]帰[00:18.37]り[00:18.55]道[00:18.94]は[00:19.22]")]
[TestCase("帰り道は", new[] { "[1,start]:18370", "[2,start]:18550", "[3,start]:18940", "[3,end]:19220" }, "帰[00:18.37]り[00:18.55]道[00:18.94]は[00:19.22]")]
[TestCase("帰り道は", new[] { "[0,start]:17970", "[1,start]:18370", "[2,start]:18550", "[3,start]:18940" }, "[00:17.97]帰[00:18.37]り[00:18.55]道[00:18.94]は")]
[TestCase("帰り道は", new string[] { }, "帰り道は")]
[TestCase("", new string[] { }, "")]
public void TestEncode(string text, string[] timeTags, string expected)
private static IEnumerable<object[]> testDecodeSource => new object[][]
{
[
"[00:17:97]帰[00:18:37]り[00:18:55]道[00:18:94]は[00:19:22]",
new KarLyric
{
Text = "帰り道は",
TimeTags = TestCaseTagHelper.ParseTimeTags(["[0,start]:17970", "[1,start]:18370", "[2,start]:18550", "[3,start]:18940", "[3,end]:19220"]),
},
],
[
"帰[00:18:37]り[00:18:55]道[00:18:94]は[00:19:22]",
new KarLyric
{
Text = "帰り道は",
TimeTags = TestCaseTagHelper.ParseTimeTags(["[1,start]:18370", "[2,start]:18550", "[3,start]:18940", "[3,end]:19220"]),
},
],
[
"[00:17:97]帰[00:18:37]り[00:18:55]道[00:18:94]は",
new KarLyric
{
Text = "帰り道は",
TimeTags = TestCaseTagHelper.ParseTimeTags(["[0,start]:17970", "[1,start]:18370", "[2,start]:18550", "[3,start]:18940"]),
},
],
[
"帰り道は",
new KarLyric
{
Text = "帰り道は",
TimeTags = [],
},
],
[
"",
new KarLyric
{
Text = "",
TimeTags = [],
},
],
[
null!,
new KarLyric
{
Text = "",
TimeTags = [],
},
],
};

[TestCaseSource(nameof(testEncodeSource))]
public void TestEncode(KarLyric lyric, string expected)
{
var lyric = new KarLyric
{
Text = text,
TimeTags = TestCaseTagHelper.ParseTimeTags(timeTags),
};
var actual = Encode(lyric);

Assert.That(actual, Is.EqualTo(expected));
}

private static IEnumerable<object[]> testEncodeSource => new object[][]
{
[
new KarLyric
{
Text = "帰り道は",
TimeTags = TestCaseTagHelper.ParseTimeTags(["[0,start]:17970", "[1,start]:18370", "[2,start]:18550", "[3,start]:18940", "[3,end]:19220"]),
},
"[00:17.97]帰[00:18.37]り[00:18.55]道[00:18.94]は[00:19.22]",
],
[
new KarLyric
{
Text = "帰り道は",
TimeTags = TestCaseTagHelper.ParseTimeTags(["[1,start]:18370", "[2,start]:18550", "[3,start]:18940", "[3,end]:19220"]),
},
"帰[00:18.37]り[00:18.55]道[00:18.94]は[00:19.22]",
],
[
new KarLyric
{
Text = "帰り道は",
TimeTags = TestCaseTagHelper.ParseTimeTags(["[0,start]:17970", "[1,start]:18370", "[2,start]:18550", "[3,start]:18940"]),
},
"[00:17.97]帰[00:18.37]り[00:18.55]道[00:18.94]は",
],
[
new KarLyric
{
Text = "帰り道は",
TimeTags = [],
},
"帰り道は",
],
[
new KarLyric
{
Text = "",
TimeTags = [],
},
"",
],
};
}
158 changes: 125 additions & 33 deletions LrcParser.Tests/Parser/Kar/Lines/KarRubyParserTest.cs
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
// Copyright (c) karaoke.dev <[email protected]>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text.

using System;
using System.Collections.Generic;
using LrcParser.Parser.Kar.Lines;
using LrcParser.Parser.Kar.Metadata;
using LrcParser.Tests.Helper;
Expand All @@ -22,47 +24,137 @@ public void TestCanDecode(string text, bool expected)
Assert.That(actual, Is.EqualTo(expected));
}

[TestCase("@Ruby1=帰,かえ,[00:53:19],[01:24:77]", "帰", "かえ", new string[] { }, 53190, 84770)]
[TestCase("@Ruby1=帰,かえ,[01:24:77]", "帰", "かえ", new string[] { }, 84770, null)]
[TestCase("@Ruby1=帰,かえ,,[01:24:77]", "帰", "かえ", new string[] { }, null, 84770)]
[TestCase("@Ruby1=帰,かえ", "帰", "かえ", new string[] { }, null, null)]
[TestCase("@Ruby1=帰,か[00:00:50]え", "帰", "かえ", new[] { "[1,start]:500" }, null, null)]
public void TestDecode(string rubyTag, string parent, string ruby, string[] timeTags, int? startTime, int? endTime)
[TestCaseSource(nameof(testDecodeSource))]
public void TestDecode(string rubyTag, KarRuby expected)
{
var expected = new KarRuby
{
Parent = parent,
Ruby = ruby,
TimeTags = TestCaseTagHelper.ParseTimeTags(timeTags),
StartTime = startTime,
EndTime = endTime,
};
var actual = Decode(rubyTag);

Assert.That(actual.Ruby, Is.EqualTo(expected.Ruby));
Assert.That(actual.Parent, Is.EqualTo(expected.Parent));
Assert.That(actual.TimeTags, Is.EqualTo(expected.TimeTags));
Assert.That(actual.StartTime, Is.EqualTo(expected.StartTime));
Assert.That(actual.EndTime, Is.EqualTo(expected.EndTime));
Assert.That(actual, Is.EqualTo(expected));
}

[TestCase("帰", "かえ", new string[] { }, 53190, 84770, "@Ruby1=帰,かえ,[00:53.19],[01:24.77]")]
[TestCase("帰", "かえ", new string[] { }, 84770, null, "@Ruby1=帰,かえ,[01:24.77]")]
[TestCase("帰", "かえ", new string[] { }, null, 84770, "@Ruby1=帰,かえ,,[01:24.77]")]
[TestCase("帰", "かえ", new string[] { }, null, null, "@Ruby1=帰,かえ")]
[TestCase("帰", "かえ", new[] { "[1,start]:500" }, null, null, "@Ruby1=帰,か[00:00.50]え")]
public void TestEncode(string parent, string ruby, string[] timeTags, int? startTime, int? endTime, string expected)
private static IEnumerable<object[]> testDecodeSource => new object[][]
{
[
"@Ruby1=帰,かえ,[00:53:19],[01:24:77]",
new KarRuby
{
Parent = "帰",
Ruby = "かえ",
TimeTags = TestCaseTagHelper.ParseTimeTags(Array.Empty<string>()),
StartTime = 53190,
EndTime = 84770,
},
],
[
"@Ruby1=帰,かえ,[01:24:77]",
new KarRuby
{
Parent = "帰",
Ruby = "かえ",
TimeTags = TestCaseTagHelper.ParseTimeTags(Array.Empty<string>()),
StartTime = 84770,
EndTime = null,
},
],
[
"@Ruby1=帰,かえ,,[01:24:77]",
new KarRuby
{
Parent = "帰",
Ruby = "かえ",
TimeTags = TestCaseTagHelper.ParseTimeTags(Array.Empty<string>()),
StartTime = null,
EndTime = 84770,
},
],
[
"@Ruby1=帰,かえ",
new KarRuby
{
Parent = "帰",
Ruby = "かえ",
TimeTags = TestCaseTagHelper.ParseTimeTags(Array.Empty<string>()),
StartTime = null,
EndTime = null,
},
],
[
"@Ruby1=帰,か[00:00:50]え",
new KarRuby
{
Parent = "帰",
Ruby = "かえ",
TimeTags = TestCaseTagHelper.ParseTimeTags(new[] { "[1,start]:500" }),
StartTime = null,
EndTime = null,
},
],
};

[TestCaseSource(nameof(testEncodeSources))]
public void TestEncode(KarRuby rubyTag, string expected)
{
var rubyTag = new KarRuby
{
Parent = parent,
Ruby = ruby,
TimeTags = TestCaseTagHelper.ParseTimeTags(timeTags),
StartTime = startTime,
EndTime = endTime,
};
var actual = Encode(rubyTag);

Assert.That(actual, Is.EqualTo(expected));
}

private static IEnumerable<object[]> testEncodeSources => new object[][]
{
[
new KarRuby
{
Parent = "帰",
Ruby = "かえ",
TimeTags = [],
StartTime = 53190,
EndTime = 84770,
},
"@Ruby1=帰,かえ,[00:53.19],[01:24.77]",
],
[
new KarRuby
{
Parent = "帰",
Ruby = "かえ",
TimeTags = [],
StartTime = 84770,
EndTime = null,
},
"@Ruby1=帰,かえ,[01:24.77]",
],
[
new KarRuby
{
Parent = "帰",
Ruby = "かえ",
TimeTags = [],
StartTime = null,
EndTime = 84770,
},
"@Ruby1=帰,かえ,,[01:24.77]",
],
[
new KarRuby
{
Parent = "帰",
Ruby = "かえ",
TimeTags = [],
StartTime = null,
EndTime = null,
},
"@Ruby1=帰,かえ",
],
[
new KarRuby
{
Parent = "帰",
Ruby = "かえ",
TimeTags = TestCaseTagHelper.ParseTimeTags(["[1,start]:500"]),
StartTime = null,
EndTime = null,
},
"@Ruby1=帰,か[00:00.50]え",
],
};
}
4 changes: 3 additions & 1 deletion LrcParser.Tests/Parser/Lines/BaseSingleLineParserTest.cs
View file
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
// Copyright (c) karaoke.dev <[email protected]>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text.

using System;
using LrcParser.Parser.Lines;

namespace LrcParser.Tests.Parser.Lines;

public class BaseSingleLineParserTest<TParser, TModel> where TParser : SingleLineParser<TModel>, new() where TModel : class
public class BaseSingleLineParserTest<TParser, TModel>
where TParser : SingleLineParser<TModel>, new() where TModel : struct, IEquatable<TModel>
{
protected bool CanDecode(string text) => new TParser().CanDecode(text);

Expand Down
Loading

0 comments on commit 736a814

Please sign in to comment.