#1257 Kapitan does not prune Kadet input

[JordanLloydHall]

Fixes #1257

Proposed Changes

• KapitanInputTypeKadetConfig.prune defaults to False instead of True (inherited).
• Type hint for KapitanInputTypeJsonnetConfig.prune is consistent with KapitanInputTypeBaseConfig.prune.

[gburiola]

Hey @alledm.

What do you think of making this default to False in the baseconfig on line 36?

I also noticed that configuring this in the inventory (prune: false) config does not work

parameters:
  kapitan:
    compile:

    - output_path: manifests
      input_type: kadet
      output_type: yaml
      prune: false

[ademariag]

Yes makes sense. this is something that didn't notice. will fix it soon

[JordanLloydHall]

Ideally this should be default None as the setting precedence seems to be:

1. This class' prune attribute.
2. The prune cmd/dot setting.
3. Default False.

Although while this key exists in the class at all, neither the cmd nor the dot files will do anything. This is because we check if the prune key exists rather than checking if an attempt to get it's value returns None at the relevant call sites.