WIP: Add Nix Flake support #867
Conversation
demusdev
force-pushed
the
feature/nix-flake
branch
from
15a1434 to
238613b
Compare
flake.nix
Outdated
| { | ||
| devShells.default = with pkgs; mkShell { | ||
| buildInputs = [ | ||
| rust-bin.nightly."2024-06-13".default |
There was a problem hiding this comment.
Is it possible to read this value from rust-toolchain file to avoid having to keep the two in sync?
There was a problem hiding this comment.
I think so. I was planning to try this in further iterations.
|
|
||
| inputs = { | ||
| nixpkgs.url = "github:NixOS/nixpkgs/nixos-unstable"; | ||
| rust-overlay.url = "github:oxalica/rust-overlay"; |
There was a problem hiding this comment.
As a beginner NixOS user myself I'm pretty excited to see this ... but at the same time worried about pushing OS/package-manager-specific stuff into the repo root that will not be used (and therefore cannot be maintained) by the whole team.
On one hand, the ease of setup this offers for Nix users is pretty great - you can get all dev dependencies in seconds. It also guarantees that same exact versions of e.g. flatbuffers and protobuf are used, which is a real concern in our current setup.
On the other hand, I question whether it's a good idea to have e.g. kubo in here as it may result in user having two versions of kubo (system-wide, and one in the flake). In my NixOS I have installed rust via rustup and the rest of dependencies as my system packages and that seems to work OK.
Will need to think on this a bit more. Perhaps having this flake just as a "best-effort support" feature would be valuable enough.
Thanks a lot for contributing this though!
There was a problem hiding this comment.
Thanks for the comments!
I don't think it would be a big harm to have flake in repo despite only a few people will using it. I definitely don't propose it as the only or the main way to setup dev env. My idea was to have a kind of automation of setup described in DEVELOPER.md, so new contributors could have (isolated) environment immediately. For instance, I like how I can fetch Helix code, enter nix develop shell and build it, and also have rust-analyzer available in my editor.
But I understand that you as a maintainer want to be very careful with adding new things to the repo.
Anyway, I created this PR more as a starting point of discussion than something to be merged immediately.
I plan to push flake file to parent directory and continue extending it, so there will be something for start when you'll consider having flake in the repo.
Should I close this PR or keep it as a reminder?
There was a problem hiding this comment.
Let's keep this open for sure. I want to find time to test it and perhaps contribute too.
Would be cool to eventually use this to automate things like all the cargo plugins that we currently suggest to install manually.
Hopefully we'll get to a point where flakes can also be used in Github CI actions :)
But lots of things to figure out still. For example I'd like to avoid duplicating this flake into kamu-node repo and risking flake.lock files going out of sync and bloating the host system. Perhaps the right direction would be to have a "kamu-wide" flake that bring in Rust, Node JS for our Web UI etc.
There was a problem hiding this comment.
I'm very new to nix and don't have an idea atm how to organise it better, but eager to experiment.
Hopefully we'll get to a point where flakes can also be used in Github CI actions :)
That would be perfect nix usage I believe.
Description
Closes: #issue
Checklist before requesting a review