Skip to content

Commit

Permalink
fix: Time listener not removed when unmounting activity (closes #900)
Browse files Browse the repository at this point in the history
  • Loading branch information
claustres committed Jul 11, 2024
1 parent cdb578f commit 5b12ab4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion map/client/mixins/globe/mixin.geojson-layers.js
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ export const geojsonLayers = {
this.geojsonCache = {}
},
beforeUnmount () {
this.$events.off('time-current-time-changed', this.onCurrentTimeChangedHeatmapLayers)
this.$events.off('time-current-time-changed', this.onCurrentTimeChangedGeoJsonLayers)
this.$engineEvents.off('layer-shown', this.onLayerShownGeoJsonLayers)
this.$engineEvents.off('layer-removed', this.onLayerRemovedGeoJsonLayers)

Expand Down
2 changes: 1 addition & 1 deletion map/client/mixins/map/mixin.geojson-layers.js
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,7 @@ export const geojsonLayers = {
this.geojsonCache = {}
},
beforeUnmount () {
this.$events.off('time-current-time-changed', this.onCurrentTimeChangedHeatmapLayers)
this.$events.off('time-current-time-changed', this.onCurrentTimeChangedGeoJsonLayers)
this.$engineEvents.off('selected-level-changed', this.onCurrentLevelChangedGeoJsonLayers)
this.$engineEvents.off('zoomend', this.onMapZoomChangedGeoJsonLayers)
this.$engineEvents.off('layer-shown', this.onLayerShownGeoJsonLayers)
Expand Down

0 comments on commit 5b12ab4

Please sign in to comment.