Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rockchip specific logo container format #663

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

armijnhemel
Copy link
Collaborator

This PR adds a spec for a format used by Rockchip on at least some of their eInk devices. I could not find any specification about what the fields are whatsoever, but it seems to be fairly simple (height and width are quite obvious when searching for the particular chipset). My guess is that what I am calling unknown_2 is probably a setting for the image quality and unknown_3 could perhaps be X/Y coordinates.

The data itself: possibly something raw or BMPs without a header (which is not uncommon on Android).

@KOLANICH
Copy link
Contributor

One field is called magic and another one is signature... Feels a bit inconsistent.

@KOLANICH
Copy link
Contributor

size: 64
....
size-eos: true

May it have sense to just replace size-eos with the needed size?

@armijnhemel
Copy link
Collaborator Author

One field is called magic and another one is signature... Feels a bit inconsistent.

Perhaps. One is for the top level identifier, the other for the individual image entries. I don't really care about what it's called.

@armijnhemel
Copy link
Collaborator Author

size: 64
....
size-eos: true

May it have sense to just replace size-eos with the needed size?

I don't see a good reason to. This looked like the cleanest solution to me at the moment, because there are no specifications whatsoever so I don't even know what the rest of the data means (and I only have two test files).

@KOLANICH
Copy link
Contributor

I guess image_entry should be nested into images, shouldn't it?

@armijnhemel
Copy link
Collaborator Author

I guess image_entry should be nested into images, shouldn't it?

As far as I know it is nested (clicking through it in the Web IDE now), so I don't know what you mean exactly.

@KOLANICH
Copy link
Contributor

Now it is

types:
  images:
    ...
  image_entry:

, but I propose it be

types:
  images:
    ...
    types:
      image_entry:

@armijnhemel
Copy link
Collaborator Author

Now it is

types:
  images:
    ...
  image_entry:

, but I propose it be

types:
  images:
    ...
    types:
      image_entry:

Ah. Personally I think it is just fine as it is and functionality wise it doesn't matter.

@generalmimon what do you think? The style guide doesn't have a recommendation for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants