Tomyeh improvements #170
Open
Tomyeh improvements #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue #167 reported a bug in line 197. I am not really sure, why the dart analyzer doesn't warn us that the types could be different. Setting the type of `text` to `String` (instead of `String?`) and giving it '' as initial value should fix this bug.
close2
commented
Mar 28, 2021
|
|
||
| Address([this.mailAddress, this.name]); | ||
| const Address(this.mailAddress, [this.name]); |
There was a problem hiding this comment.
Do we always require an address?
close2
commented
Mar 28, 2021
| @@ -173,7 +173,7 @@ class _IRContentAttachment extends _IRContent { | |||
| enum _IRTextType { plain, html } | |||
|
|
|||
| class _IRContentText extends _IRContent { | |||
| String? _text; | |||
| String _text = ''; | |||
There was a problem hiding this comment.
This should fix the bug mentioned in #167
will improve commit message later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.