fix(wolff_client): keep metadata connection alive #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
force-pushed
the
long-live-metadata-connection
branch
2 times, most recently
from
c126a34 to
c747c9c
Compare
ieQu1
approved these changes
Feb 7, 2024
zmstone
force-pushed
the
long-live-metadata-connection
branch
from
c747c9c to
3063765
Compare
|
added another test case after @ieQu1's approval. |
thalesmg
approved these changes
Feb 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some environments (e.g. Azure Event Hubs) appears to have a connection rate limit.
tcpdump suggested TCP SYN packet being retransmitted before the connectivity check returned error.
This PR keeps the client's metadata connection alive (instead of immediately close after usage).
And the connectivity check returns
okimmediately if the connection process is alive.