Skip to content

Commit

Permalink
Merge pull request #615 from zmstone/241214-catch-all-exit-exceptions…
Browse files Browse the repository at this point in the history
…-when-coordinator-call-member

Catch all exit exceptions when coordinator call member
  • Loading branch information
zmstone authored Dec 14, 2024
2 parents 40a6ef6 + 2b018ea commit e1a36e0
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
# Changelog

- 4.3.3
- Catch `exit` exception when group coordinator calls group member (owner) process.
- Add `unknown_topic_cache_ttl` option in client config.
- Doc improvements.

- 4.3.2
- Upgrade kafka_protocol from 4.1.9 to 4.1.10 for partition leader discover/connect timeout fix.
- Upgrade kafka_protocol from 4.1.9 to 4.1.10 for partition leader discover/connect timeout fix.

- 4.3.1
- Fixed `brod_client:stop_consumer` so that it doesn't crash the client process if an unknown consumer is given as argument.
Expand Down
6 changes: 4 additions & 2 deletions src/brod_group_coordinator.erl
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,10 @@
try
EXPR
catch
exit:{noproc, {gen_server, call, [MemberPid | _]}} ->
exit({shutdown, member_down})
exit:{noproc, _} ->
exit({shutdown, member_down});
exit:{Reason, _} ->
exit({shutdown, {member_down, Reason}})
end).

-type config() :: brod:group_config().
Expand Down

0 comments on commit e1a36e0

Please sign in to comment.