-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BE: Chore: remove unnecessary architecture check in unit test #704
base: main
Are you sure you want to change the base?
Conversation
9638ce4
to
a92c50d
Compare
This didn't work previously for some reason, have you tried running it on arm? |
d6b3689
to
a92c50d
Compare
This doesn't work, running tests brings up non-arm 7.2.1:
|
a92c50d
to
dc79429
Compare
@Haarolean I am surprised that this happened because I had success in another M1 Mac with this. When I tested this I used the multi-platform hash instead of a tag and I am not sure if that matters Could you please share the output of
After that, I am curious what you see if you run using the Multi-platform digest instead:
Also, could please confirm what version of docker are you using? |
What changes did you make? (Give an overview)
The existing logic was unnecessary because the
confluentinc/cp-kafka
image is a multi-platform image and the docker engine will pick the appropriate version as neededHow Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
A picture of a cute animal (not mandatory but encouraged)