[maintenance] bump golangci-lint to latest #1802
Open
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuritka
requested review from
donovanmuller,
k0da,
ytsarev,
jkremser and
abaguas
as code owners
Signed-off-by: Michal Kuritka <[email protected]>
kuritka
force-pushed
the
bump-golangci-lint
branch
from
f0249e7 to
14fa3a0
Compare
ytsarev
reviewed
Jan 18, 2025
| @@ -227,6 +227,7 @@ func (p *InfobloxProvider) saveHeartbeatTXTRecord(objMgr *ibcl.ObjectManager, gs | |||
| log.Info(). | |||
| Str("HeartbeatTXTName", heartbeatTXTName). | |||
| Msg("Creating split brain TXT record") | |||
| //nolint:gosec | |||
There was a problem hiding this comment.
@kuritka, can we document the skipping of this linter? Without additional comment, it looks slightly insecure :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bumping golangci-lint to latest