Fixing k3s uninstallation failures when k3s is installed via airgap role #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gap role Signed-off-by: SakshamAbhi <[email protected]>
SakshamAbhi
force-pushed
the
uninstall_airgap
branch
from
dbfd006 to
61c1450
Compare
dereknola
approved these changes
Dec 24, 2024
|
Thank you for reviewing the PR! Can you also approve the pending workflow so that the checks can run? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
These changes will make sure:
k3s.serviceis only installed for server group.k3s-agent.serviceis only installed for agent group.As we will only have the expected service installed on the node,
k3s-uninstall.shscript will seamlessly clean up the cluster during teardown.Linked Issues
#383