-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC: Supporting k3s-ansible with external database #339
Conversation
5be393f
to
e5bbe6d
Compare
If you rebase off master, you won't see the lint error around ansible 2.14 anymore. |
Signed-off-by: Peter Klijn <[email protected]>
e5bbe6d
to
ef17880
Compare
Signed-off-by: Peter Klijn <[email protected]>
d20f1ad
to
f86910a
Compare
Signed-off-by: Peter Klijn <[email protected]>
Signed-off-by: Peter Klijn <[email protected]>
45190fe
to
bbeb175
Compare
Hi @dereknola, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, was offsite all last week. This should fix all the lint. As use_external_database
is already defined with a default bool value, all attempts to override it must also be a bool, eliminating the need to filter | bool
in the when clauses.
Signed-off-by: Peter Klijn <[email protected]>
Thanks for the review! I've processed your comments 👍 |
* POC: Supporting k3s-ansible with external database Signed-off-by: Peter Klijn <[email protected]>
Changes
A (working) proof of concept of supporting external databases in this Ansible setup.
This change introduces an option variable
use_external_database
, which if present uses thek3s-single.service.j2
template, regardless of how many server hosts are defined.Using this together with the
extra_server_args
variable to pass along a--datastore-endpoint
will create a K3s setup using an external datastore.Linked Issues
#340