Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom context name #315

Merged

Conversation

vrsarin
Copy link
Contributor

@vrsarin vrsarin commented Mar 29, 2024

Changes

Added a variable called cluster_context to replace hardcoded cluster context name

Linked Issues

@dereknola
Copy link
Member

@vrsarin Please address the lint errors. Otherwise LGTM.

@vrsarin
Copy link
Contributor Author

vrsarin commented Mar 29, 2024

@vrsarin Please address the lint errors. Otherwise LGTM.

@dereknola Fixed the linitng issues. Please approve.

Signed-off-by: Vivek Sarin <[email protected]>
@dereknola dereknola force-pushed the feature/issue313_add_cluster_context_name branch from 010051b to 52bbbee Compare March 29, 2024 19:59
Copy link
Member

@dereknola dereknola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a lint fix. It was actually just complaining about a empty space at the end of line 137.

roles/k3s_server/tasks/main.yml Outdated Show resolved Hide resolved
Signed-off-by: Derek Nola <[email protected]>
@dereknola dereknola force-pushed the feature/issue313_add_cluster_context_name branch from 52bbbee to 77248c4 Compare March 29, 2024 20:10
Signed-off-by: Vivek Sarin <[email protected]>
@vrsarin
Copy link
Contributor Author

vrsarin commented Mar 29, 2024

@dereknola removed the line. Please approve.

Signed-off-by: Derek Nola <[email protected]>
@dereknola dereknola merged commit c84c1ce into k3s-io:master Apr 1, 2024
2 checks passed
@vrsarin vrsarin deleted the feature/issue313_add_cluster_context_name branch April 3, 2024 18:35
steevi pushed a commit to steevi/k3s-ansible that referenced this pull request Jul 2, 2024
* Added custom context name

Signed-off-by: Vivek Sarin <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Co-authored-by: Vivek Sarin <[email protected]>
Co-authored-by: Derek Nola <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants