Fix unexpected behaviour when kubeconfig is set
#296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As detailed in k3s-io#295, this commit fixes the issue that if `kubeconfig` is set to anything other than the defaults value, then: - `~/.kube/config` is modified. - No file at `{{ kubeconfig }}` is created. - Any existing file and `{{ kubeconfig }}` is deleted. Signed-off-by: Nick To <[email protected]>
nickto
force-pushed
the
fix-295-wrong-kubeconfig-behaviour
branch
from
9739fd1 to
b35ec3a
Compare
dereknola
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As detailed in #295, this merge request fixes the issue that if
kubeconfigis set to a value other than~/.kube/config, then:~/.kube/configis modified.{{ kubeconfig }}is created.{{ kubeconfig }}is deleted.Changes
KUBECONFIGpath tokubectlcommands.{{ kubeconfig }}.Linked Issues
#295