Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bindings): expose sequence alignment to TM_result object #41

Merged
merged 2 commits into from
Jul 14, 2024
Merged

feat(bindings): expose sequence alignment to TM_result object #41

merged 2 commits into from
Jul 14, 2024

Conversation

cvigilv
Copy link
Contributor

@cvigilv cvigilv commented Jul 14, 2024

  • feat(bindings): expose sequence alignment from TMalign
  • test: sequence alignment for identical and segments

@cvigilv cvigilv changed the title feat(bindings): expose sequence alignment to TMResult feat(bindings): expose sequence alignment to TMResultobject Jul 14, 2024
@cvigilv
Copy link
Contributor Author

cvigilv commented Jul 14, 2024

Closes #33

@cvigilv cvigilv changed the title feat(bindings): expose sequence alignment to TMResultobject feat(bindings): expose sequence alignment to TM_resultobject Jul 14, 2024
@cvigilv cvigilv changed the title feat(bindings): expose sequence alignment to TM_resultobject feat(bindings): expose sequence alignment to TM_result object Jul 14, 2024
jvkersch
jvkersch approved these changes Jul 14, 2024
View reviewed changes
Copy link
Owner

@jvkersch jvkersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (LGTM)! I did not realize that the alignment was already handled via parameters.

@jvkersch jvkersch merged commit 9d8a0d3 into jvkersch:main Jul 14, 2024
15 checks passed
@jvkersch
Copy link
Owner

Ah, just a small remark: the closes #33 should appear in the PR description in order for it to automatically close the associated issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvkersch jvkersch jvkersch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cvigilv @jvkersch