Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [ADYEN, WORLDPAY ] Consume transaction id for error cases #7061

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(connector): [ADYEN, WORLDPAY ] Consume transaction id for error cases #7061

wants to merge 1 commit into from

Conversation

cookieg13
Copy link
Contributor

@cookieg13 cookieg13 commented Jan 17, 2025 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

To consume transaction id for some error cases , where currently its not consumed for Adyen, Worldpay. This PR addresses this issue.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

By manually giving wrong connector credentials for Worldpay and hitting /payments
Before
Screenshot 2025-01-17 at 18 22 50
After
Screenshot 2025-01-17 at 17 33 23

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@cookieg13 cookieg13 requested a review from a team as a code owner January 17, 2025 11:28
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Jan 17, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/hyperswitch_connectors/src/connectors/worldpay.rs  0% smaller
  crates/router/src/connector/adyen.rs  0% smaller

@cookieg13 cookieg13 self-assigned this Jan 17, 2025
@cookieg13 cookieg13 added the A-connector-integration Area: Connector integration label Jan 17, 2025
mrudulvajpayee4935
mrudulvajpayee4935 reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@mrudulvajpayee4935 mrudulvajpayee4935 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to use correlation_id as connector_transaction_id here?

@cookieg13
Copy link
Contributor Author

do we need to use correlation_id as connector_transaction_id here?

yes, we are using optional_correlation_id as connector_transaction_id in other places in case of Worldpay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrudulvajpayee4935 mrudulvajpayee4935 mrudulvajpayee4935 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@cookieg13 cookieg13

Labels
A-connector-integration Area: Connector integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cookieg13 @mrudulvajpayee4935