Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): [NETCETERA] add accept-language in browser_information for netcetera authentication request #7059

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

sai-harsha-vardhan
Copy link
Contributor

@sai-harsha-vardhan sai-harsha-vardhan commented Jan 17, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Missing BrowserInformation.AcceptLanguage in Authentication request for Netcetera

  • add accept-language in browser_information for netcetera authentication request

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested Manually
External 3DS authentication request through Netcetera
CURL

curl --location '{{baseURL}}/payments/{{PAYMENT_ID}}/3ds/authentication' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: {{PUBLISHABLE_KEY}}' \
--data '{
    "client_secret": "pay_YgaqwRsJ2D609GavM4R7_secret_dyidRAo6cvSM5Wfbc4Se",
    "device_channel": "BRW",
    "threeds_method_comp_ind": "Y"
}'

Response

{
    "trans_status": "Y",
    "acs_url": null,
    "challenge_request": null,
    "acs_reference_number": null,
    "acs_trans_id": null,
    "three_dsserver_trans_id": "0fa5cf1b-dd17-4314-8fb0-6ef51367a32b",
    "acs_signed_content": null,
    "three_ds_requestor_url": "https://google.com/"
}

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@sai-harsha-vardhan sai-harsha-vardhan added A-connector-integration Area: Connector integration C-bug Category: Bug labels Jan 17, 2025
@sai-harsha-vardhan sai-harsha-vardhan self-assigned this Jan 17, 2025
@sai-harsha-vardhan sai-harsha-vardhan requested a review from a team as a code owner January 17, 2025 11:05
Copy link

semanticdiff-com bot commented Jan 17, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/connector/netcetera/netcetera_types.rs  47% smaller

@sai-harsha-vardhan sai-harsha-vardhan changed the title fix(connector): [NETCETERA] add accept-language in browser_information for netcetera fix(connector): [NETCETERA] add accept-language in browser_information for netcetera authentication request Jan 17, 2025
@likhinbopanna likhinbopanna added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit aa8e2e7 Jan 17, 2025
29 of 32 checks passed
@likhinbopanna likhinbopanna deleted the add-accept-language-netcetera branch January 17, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants