Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(euclid): update proto file for elimination routing #7032

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

prajjwalkumar17
Copy link
Contributor

@prajjwalkumar17 prajjwalkumar17 commented Jan 13, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This will update the proto file for elimination routing to include the global rates. This is basically done in order to keep the proto file upto-date with dynamic routing service.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Testing isn't required as this is only env change

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@prajjwalkumar17 prajjwalkumar17 requested a review from a team as a code owner January 13, 2025 08:39
Copy link

Review changes with  SemanticDiff

@prajjwalkumar17 prajjwalkumar17 self-assigned this Jan 16, 2025
@prajjwalkumar17 prajjwalkumar17 added the A-routing Area: Routing label Jan 16, 2025
@prajjwalkumar17 prajjwalkumar17 added this to the December 2024 Release milestone Jan 16, 2025
@prajjwalkumar17 prajjwalkumar17 linked an issue Jan 16, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-routing Area: Routing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(euclid): update proto file for elimination routing
2 participants