Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable 128-column-tables feature for diesel crate #6857

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

chore: enable 128-column-tables feature for diesel crate #6857

wants to merge 8 commits into from

Conversation

hrithikesh026
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

enabled 128-column-tables feature for diesel crate in diesel_models and common_enums crate. In order to accumulate future addition of columns in payment_attempt

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

cargo check

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@hrithikesh026 hrithikesh026 self-assigned this Dec 17, 2024
@hrithikesh026 hrithikesh026 requested a review from a team as a code owner December 17, 2024 08:57
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@hrithikesh026 hrithikesh026 added the increases-compile-time This change increases compilation time label Dec 17, 2024
SanchithHegde
SanchithHegde previously approved these changes Dec 17, 2024
View reviewed changes
jarnura
jarnura previously approved these changes Dec 17, 2024
View reviewed changes
@SanchithHegde SanchithHegde added this pull request to the merge queue Dec 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 17, 2024
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Dec 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 19, 2024
@hrithikesh026 hrithikesh026 dismissed stale reviews from jarnura and SanchithHegde via d242716 January 15, 2025 06:52
@hrithikesh026 hrithikesh026 requested a review from a team as a code owner January 15, 2025 06:52
SanchithHegde
SanchithHegde previously approved these changes Jan 15, 2025
View reviewed changes
Narayanbhat166
Narayanbhat166 previously approved these changes Jan 15, 2025
View reviewed changes
@likhinbopanna likhinbopanna added this pull request to the merge queue Jan 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 16, 2025
SanchithHegde
SanchithHegde previously approved these changes Jan 16, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 left review comments

@SanchithHegde SanchithHegde SanchithHegde left review comments

@jarnura jarnura jarnura left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@hrithikesh026 hrithikesh026

Labels
increases-compile-time This change increases compilation time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hrithikesh026 @jarnura @SanchithHegde @Narayanbhat166