Skip to content

Commit

Permalink
Fix unhandled_handler configuration
Browse files Browse the repository at this point in the history
Custom unhandled_handler configuration fix. It wouldn't let you set a custom one as the validation was checking for `is_a?` instead of `<`
  • Loading branch information
jusleg committed Mar 25, 2019
1 parent 8902d96 commit 45586af
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 4 deletions.
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
##V0.1.3
## V0.1.4

Custom unhandled_handler configuration fix. It wouldn't let you set a custom one as the validation was checking for `is_a?` instead of `<`

## V0.1.3
Added `remove_unhandled_handler` as a configuration option to disable the unhandled handler.

## V0.1.2
Expand Down
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
slackify (0.1.3)
slackify (0.1.4)
rails
slack-ruby-client

Expand Down
2 changes: 1 addition & 1 deletion lib/slackify/configuration.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def initialize

def unhandled_handler=(handler)
raise Exceptions::InvalidHandler, "#{handler.class} is not a subclass of Slackify::Handlers::Base" unless
handler.is_a?(Handlers::Base)
handler < Handlers::Base

@unhandled_handler = handler
end
Expand Down
2 changes: 1 addition & 1 deletion slackify.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Gem::Specification.new do |s|
s.name = 'slackify'
s.version = '0.1.3'
s.version = '0.1.4'
s.date = '2019-03-17'
s.summary = 'Slackbot framework for Rails using the Events API'
s.description = 'Slackbot framework for Rails using the Events API. Supports events, interactive messages and slash commands.'
Expand Down

0 comments on commit 45586af

Please sign in to comment.