Add correct install instructions #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, that's a good idea, thank you for the changes. |
|
I don't know if you're interested in implementing further improvements (Issues are currently disabled), and if not please ignore, but by similar reasoning as the above it might be nice to also merge in things like this PR: jwkvam/jupyterlab-vim#112 |
|
At first, I wasn't planning on doing further improvements, but I will think about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your repo is currently the first jupyterlab_vim extension that someone will find when looking for a jlab2 compatible version. So I updated the install instructions to make them copy pasteable.
I didn't add to history because its not clear if this warrants an entry there?
History.mdbriefly documenting the change.