Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to MathJax 3 #1691

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

gwincr11
Copy link
Contributor

@gwincr11 gwincr11 commented Dec 16, 2021

Motivation:

  • This pr starts to update the nbconvert app to use MathJax 3.
    MathJax 3 does not use inline script execution to pull in its
    libraries which improves the security story for using this library.

Notes:

This needs some solid testing, I have yet to build a bunch of notebooks with it, although the config is based on the MathJax setup we are using at GitHub for Notebook viewing. We hope to upstream this so it can be tweaked and owned by the community and not us.

For what its worth, Reveal 4.0 introduces a MathJax plugins so I think if that was updated there could be some custom code removed as well. https://github.com/hakimel/reveal.js/releases https://618b8dc985f599ad10a72ac4--revealjs.netlify.app/math/#mathjax-3-4.2.0

Motivation:
  - This pr starts to update the nbconvert app to use MathJax 3.
    MathJax 3 does not use inline script execution to pull in its
    libraries which improves the security story for using this library.
@gwincr11
Copy link
Contributor Author

I temporarily update our app to use this branch and everything looks good. But you probably want to kick the tires yourself a bit 😅

@SylvainCorlay
Copy link
Member

Thanks! Will try to review and get this in for 6.5.

@SylvainCorlay SylvainCorlay added this to the 6.5 milestone Jan 26, 2022
@bollwyvl
Copy link
Contributor

bollwyvl commented May 9, 2022

@gwincr11 this might be a good match for the recently-initiated 7.x line on #1771: would it be possible to rebase or otherwise merge the changes on top of main?

@krassowski
Copy link
Member

Of note, we are upgrading to MathJax 3 on JupyterLab side too: jupyterlab/jupyterlab#13877. It would be nice to land both PRs at similar time for consistency.

@JeppeKlitgaard
Copy link
Contributor

Note that MathJax 4 will ship soon 🤞, thought this release should be much more backwards compatible than the 2 → 3 transition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants