Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some more tests cases #225

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

germa89
Copy link

@germa89 germa89 commented Apr 24, 2023

Adding some tests for relative path.

Related to #224

@12rambau
Copy link
Contributor

Hi all I'm a new maintainer of the package and I'll try my best to review your PR.
I would like to add your tests before making a bigger revamp of the test suit, are you still willing to work on this PR or should I merge it to a feature branch ?

@germa89
Copy link
Author

germa89 commented Dec 28, 2023

Hi ... I'm happy to help on this! Feel free to move it to a feature branch.

@12rambau
Copy link
Contributor

12rambau commented Dec 28, 2023

excellent ! Then could you for starters rebase your branch on the current main so that the test can run in github actions ?

@germa89
Copy link
Author

germa89 commented Jan 24, 2024

excellent ! Then could you for starters rebase your branch on the current main so that the test can run in github actions ?

Hi @12rambau !! Sorry for the delay. There you have!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants