Implement juyter.widget.control protocol #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoinePrv
force-pushed
the
control-target
branch
from
43cb637 to
56ab7d8
Compare
|
Tracking the behavior for destroying the |
AntoinePrv
force-pushed
the
control-target
branch
from
56ab7d8 to
541343b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes to get this going.
The implementation is currently leaking, as are all currently all things created from the frontend, even after they are closed (owningxholders).Perhaps better to address that in a separate PR
A simple fix is proposed to manage comm closed by the front-end, but the fix is sensitive to Xeus modification.
The protocol implemented is the one used in IPyWidget, but not the one documented. Tracking in
jupyter-widgets/ipywidgets#3441