Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented new base.hpp structure #191

Merged
merged 16 commits into from
Sep 16, 2022
Merged

Implemented new base.hpp structure #191

merged 16 commits into from
Sep 16, 2022

Conversation

MCWertGaming
Copy link
Collaborator

@MCWertGaming MCWertGaming commented Sep 14, 2022 •
edited
Loading

This PR implements a unified interface for 4bit / 8bit / 24bit colors and features a few new features.

Implements #190.

Also Implements partly #177, #175.

@MCWertGaming MCWertGaming added the enhancement New feature or request label Sep 14, 2022
@MCWertGaming MCWertGaming added this to the V1.0.0 milestone Sep 14, 2022
@MCWertGaming MCWertGaming requested a review from certik September 14, 2022 11:16
@MCWertGaming MCWertGaming self-assigned this Sep 14, 2022
@MCWertGaming
Copy link
Collaborator Author

Hey @flagarde would you mind reviewing the new structure?

@MCWertGaming MCWertGaming linked an issue Sep 14, 2022 that may be closed by this pull request
Concept for the CPP-Terminal V1.0.0 Interface (base.hpp) #190
Closed
@flagarde
Copy link
Collaborator

Sure, I can have a look.

@MCWertGaming
Copy link
Collaborator Author

Hey @certik would you mind trying out the colors example on MacOS? The autocolor demo on the bottom should work now since it converts the 24bit colors to 8bit ones when 24bit color support is not present. This would fix #107 and #108 if it works.

flagarde
flagarde reviewed Sep 14, 2022
View reviewed changes
Copy link
Collaborator

@flagarde flagarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a quick check, look very nice, I put some comment and will have a better look tomorrow

flagarde
flagarde reviewed Sep 14, 2022
View reviewed changes
cpp-terminal/base.hpp Outdated Show resolved Hide resolved
cpp-terminal/base.hpp Outdated Show resolved Hide resolved
cpp-terminal/base.cpp Show resolved Hide resolved
cpp-terminal/base.cpp Show resolved Hide resolved
cpp-terminal/base.cpp Outdated Show resolved Hide resolved
This was referenced Sep 15, 2022
Open
Closed
@MCWertGaming
Copy link
Collaborator Author

@flagarde would you mind to check the new changes?

@flagarde
Copy link
Collaborator

@MCWertGaming sure, let me have a look

@MCWertGaming MCWertGaming mentioned this pull request Sep 16, 2022
Open
3 tasks
flagarde
flagarde reviewed Sep 16, 2022
View reviewed changes
Copy link
Collaborator

@flagarde flagarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good :)

@MCWertGaming
Copy link
Collaborator Author

Thank you really much for reviewing this @flagarde! I have done a quick rebase and will merge once the CI finished.

@MCWertGaming MCWertGaming merged commit 246cbd6 into jupyter-xeus:master Sep 16, 2022
@MCWertGaming MCWertGaming deleted the base_header branch September 16, 2022 18:41
@MCWertGaming MCWertGaming mentioned this pull request Sep 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flagarde flagarde flagarde left review comments

@certik certik Awaiting requested review from certik

Assignees

@MCWertGaming MCWertGaming

Labels
enhancement New feature or request
Projects
CPP-Terminal
Status: Done
Milestone
V1.0.0
Development

Successfully merging this pull request may close these issues.

Concept for the CPP-Terminal V1.0.0 Interface (base.hpp)
2 participants
@MCWertGaming @flagarde