Skip to content

Commit

Permalink
Fixed typo in cin_buffer size (#350)
Browse files Browse the repository at this point in the history
  • Loading branch information
@tlane-jlg
tlane-jlg authored Jan 31, 2024
1 parent b0bd41e commit a7f469c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cpp-terminal/iostream.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ namespace
std::array<char, sizeof(Term::TOstream)> cout_buffer; //NOLINT(fuchsia-statically-constructed-objects)

Check warning on line 16 in cpp-terminal/iostream.cpp

View workflow job for this annotation

GitHub Actions / cpp-linter

cpp-terminal/iostream.cpp:16:31 [misc-include-cleaner] 

no header providing "Term::TOstream" is directly included
std::array<char, sizeof(Term::TOstream)> clog_buffer; //NOLINT(fuchsia-statically-constructed-objects)

Check warning on line 17 in cpp-terminal/iostream.cpp

View workflow job for this annotation

GitHub Actions / cpp-linter

cpp-terminal/iostream.cpp:17:31 [misc-include-cleaner] 

no header providing "Term::TOstream" is directly included
std::array<char, sizeof(Term::TOstream)> cerr_buffer; //NOLINT(fuchsia-statically-constructed-objects)

Check warning on line 18 in cpp-terminal/iostream.cpp

View workflow job for this annotation

GitHub Actions / cpp-linter

cpp-terminal/iostream.cpp:18:31 [misc-include-cleaner] 

no header providing "Term::TOstream" is directly included
std::array<char, sizeof(Term::TOstream)> cin_buffer; //NOLINT(fuchsia-statically-constructed-objects)
std::array<char, sizeof(Term::TIstream)> cin_buffer; //NOLINT(fuchsia-statically-constructed-objects)

Check warning on line 19 in cpp-terminal/iostream.cpp

View workflow job for this annotation

GitHub Actions / cpp-linter

cpp-terminal/iostream.cpp:19:31 [misc-include-cleaner] 

no header providing "Term::TIstream" is directly included
} // namespace

Term::TOstream& Term::cout = reinterpret_cast<Term::TOstream&>(cout_buffer); //NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)

Check warning on line 22 in cpp-terminal/iostream.cpp

View workflow job for this annotation

GitHub Actions / cpp-linter

cpp-terminal/iostream.cpp:22:7 [misc-include-cleaner] 

no header providing "Term::TOstream" is directly included

Check warning on line 22 in cpp-terminal/iostream.cpp

View workflow job for this annotation

GitHub Actions / cpp-linter

cpp-terminal/iostream.cpp:22:53 [misc-include-cleaner] 

no header providing "Term::TOstream" is directly included
Expand Down

1 comment on commit a7f469c

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy reports: 12 concern(s)

  • cpp-terminal/iostream.cpp

    cpp-terminal/iostream.cpp:16:31: warning: [misc-include-cleaner]

    no header providing "Term::TOstream" is directly included

       11 | 
   12 | #include <array>
   13 | 
   14 | namespace
   15 | {
   16 | std::array<char, sizeof(Term::TOstream)> cout_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
      |                               ^

    cpp-terminal/iostream.cpp:17:31: warning: [misc-include-cleaner]

    no header providing "Term::TOstream" is directly included

       11 | 
   12 | #include <array>
   13 | 
   14 | namespace
   15 | {
   16 | std::array<char, sizeof(Term::TOstream)> cout_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   17 | std::array<char, sizeof(Term::TOstream)> clog_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
      |                               ^

    cpp-terminal/iostream.cpp:18:31: warning: [misc-include-cleaner]

    no header providing "Term::TOstream" is directly included

       11 | 
   12 | #include <array>
   13 | 
   14 | namespace
   15 | {
   16 | std::array<char, sizeof(Term::TOstream)> cout_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   17 | std::array<char, sizeof(Term::TOstream)> clog_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   18 | std::array<char, sizeof(Term::TOstream)> cerr_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
      |                               ^

    cpp-terminal/iostream.cpp:19:31: warning: [misc-include-cleaner]

    no header providing "Term::TIstream" is directly included

       11 | 
   12 | #include <array>
   13 | 
   14 | namespace
   15 | {
   16 | std::array<char, sizeof(Term::TOstream)> cout_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   17 | std::array<char, sizeof(Term::TOstream)> clog_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   18 | std::array<char, sizeof(Term::TOstream)> cerr_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   19 | std::array<char, sizeof(Term::TIstream)> cin_buffer;   //NOLINT(fuchsia-statically-constructed-objects)
      |                               ^

    cpp-terminal/iostream.cpp:22:7: warning: [misc-include-cleaner]

    no header providing "Term::TOstream" is directly included

       11 | 
   12 | #include <array>
   13 | 
   14 | namespace
   15 | {
   16 | std::array<char, sizeof(Term::TOstream)> cout_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   17 | std::array<char, sizeof(Term::TOstream)> clog_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   18 | std::array<char, sizeof(Term::TOstream)> cerr_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   19 | std::array<char, sizeof(Term::TIstream)> cin_buffer;   //NOLINT(fuchsia-statically-constructed-objects)
   20 | }  // namespace
   21 | 
   22 | Term::TOstream& Term::cout = reinterpret_cast<Term::TOstream&>(cout_buffer);  //NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
      |       ^

    cpp-terminal/iostream.cpp:22:53: warning: [misc-include-cleaner]

    no header providing "Term::TOstream" is directly included

       11 | 
   12 | #include <array>
   13 | 
   14 | namespace
   15 | {
   16 | std::array<char, sizeof(Term::TOstream)> cout_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   17 | std::array<char, sizeof(Term::TOstream)> clog_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   18 | std::array<char, sizeof(Term::TOstream)> cerr_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   19 | std::array<char, sizeof(Term::TIstream)> cin_buffer;   //NOLINT(fuchsia-statically-constructed-objects)
   20 | }  // namespace
   21 | 
   22 | Term::TOstream& Term::cout = reinterpret_cast<Term::TOstream&>(cout_buffer);  //NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
      |                                                     ^

    cpp-terminal/iostream.cpp:23:7: warning: [misc-include-cleaner]

    no header providing "Term::TOstream" is directly included

       11 | 
   12 | #include <array>
   13 | 
   14 | namespace
   15 | {
   16 | std::array<char, sizeof(Term::TOstream)> cout_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   17 | std::array<char, sizeof(Term::TOstream)> clog_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   18 | std::array<char, sizeof(Term::TOstream)> cerr_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   19 | std::array<char, sizeof(Term::TIstream)> cin_buffer;   //NOLINT(fuchsia-statically-constructed-objects)
   20 | }  // namespace
   21 | 
   22 | Term::TOstream& Term::cout = reinterpret_cast<Term::TOstream&>(cout_buffer);  //NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
   23 | Term::TOstream& Term::clog = reinterpret_cast<Term::TOstream&>(clog_buffer);  //NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
      |       ^

    cpp-terminal/iostream.cpp:23:53: warning: [misc-include-cleaner]

    no header providing "Term::TOstream" is directly included

       11 | 
   12 | #include <array>
   13 | 
   14 | namespace
   15 | {
   16 | std::array<char, sizeof(Term::TOstream)> cout_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   17 | std::array<char, sizeof(Term::TOstream)> clog_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   18 | std::array<char, sizeof(Term::TOstream)> cerr_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   19 | std::array<char, sizeof(Term::TIstream)> cin_buffer;   //NOLINT(fuchsia-statically-constructed-objects)
   20 | }  // namespace
   21 | 
   22 | Term::TOstream& Term::cout = reinterpret_cast<Term::TOstream&>(cout_buffer);  //NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
   23 | Term::TOstream& Term::clog = reinterpret_cast<Term::TOstream&>(clog_buffer);  //NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
      |                                                     ^

    cpp-terminal/iostream.cpp:24:7: warning: [misc-include-cleaner]

    no header providing "Term::TOstream" is directly included

       11 | 
   12 | #include <array>
   13 | 
   14 | namespace
   15 | {
   16 | std::array<char, sizeof(Term::TOstream)> cout_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   17 | std::array<char, sizeof(Term::TOstream)> clog_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   18 | std::array<char, sizeof(Term::TOstream)> cerr_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   19 | std::array<char, sizeof(Term::TIstream)> cin_buffer;   //NOLINT(fuchsia-statically-constructed-objects)
   20 | }  // namespace
   21 | 
   22 | Term::TOstream& Term::cout = reinterpret_cast<Term::TOstream&>(cout_buffer);  //NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
   23 | Term::TOstream& Term::clog = reinterpret_cast<Term::TOstream&>(clog_buffer);  //NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
   24 | Term::TOstream& Term::cerr = reinterpret_cast<Term::TOstream&>(cerr_buffer);  //NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
      |       ^

    cpp-terminal/iostream.cpp:24:53: warning: [misc-include-cleaner]

    no header providing "Term::TOstream" is directly included

       11 | 
   12 | #include <array>
   13 | 
   14 | namespace
   15 | {
   16 | std::array<char, sizeof(Term::TOstream)> cout_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   17 | std::array<char, sizeof(Term::TOstream)> clog_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   18 | std::array<char, sizeof(Term::TOstream)> cerr_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   19 | std::array<char, sizeof(Term::TIstream)> cin_buffer;   //NOLINT(fuchsia-statically-constructed-objects)
   20 | }  // namespace
   21 | 
   22 | Term::TOstream& Term::cout = reinterpret_cast<Term::TOstream&>(cout_buffer);  //NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
   23 | Term::TOstream& Term::clog = reinterpret_cast<Term::TOstream&>(clog_buffer);  //NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
   24 | Term::TOstream& Term::cerr = reinterpret_cast<Term::TOstream&>(cerr_buffer);  //NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
      |                                                     ^

    cpp-terminal/iostream.cpp:25:7: warning: [misc-include-cleaner]

    no header providing "Term::TIstream" is directly included

       11 | 
   12 | #include <array>
   13 | 
   14 | namespace
   15 | {
   16 | std::array<char, sizeof(Term::TOstream)> cout_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   17 | std::array<char, sizeof(Term::TOstream)> clog_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   18 | std::array<char, sizeof(Term::TOstream)> cerr_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   19 | std::array<char, sizeof(Term::TIstream)> cin_buffer;   //NOLINT(fuchsia-statically-constructed-objects)
   20 | }  // namespace
   21 | 
   22 | Term::TOstream& Term::cout = reinterpret_cast<Term::TOstream&>(cout_buffer);  //NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
   23 | Term::TOstream& Term::clog = reinterpret_cast<Term::TOstream&>(clog_buffer);  //NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
   24 | Term::TOstream& Term::cerr = reinterpret_cast<Term::TOstream&>(cerr_buffer);  //NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
   25 | Term::TIstream& Term::cin  = reinterpret_cast<Term::TIstream&>(cin_buffer);   //NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
      |       ^

    cpp-terminal/iostream.cpp:25:53: warning: [misc-include-cleaner]

    no header providing "Term::TIstream" is directly included

       11 | 
   12 | #include <array>
   13 | 
   14 | namespace
   15 | {
   16 | std::array<char, sizeof(Term::TOstream)> cout_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   17 | std::array<char, sizeof(Term::TOstream)> clog_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   18 | std::array<char, sizeof(Term::TOstream)> cerr_buffer;  //NOLINT(fuchsia-statically-constructed-objects)
   19 | std::array<char, sizeof(Term::TIstream)> cin_buffer;   //NOLINT(fuchsia-statically-constructed-objects)
   20 | }  // namespace
   21 | 
   22 | Term::TOstream& Term::cout = reinterpret_cast<Term::TOstream&>(cout_buffer);  //NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
   23 | Term::TOstream& Term::clog = reinterpret_cast<Term::TOstream&>(clog_buffer);  //NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
   24 | Term::TOstream& Term::cerr = reinterpret_cast<Term::TOstream&>(cerr_buffer);  //NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
   25 | Term::TIstream& Term::cin  = reinterpret_cast<Term::TIstream&>(cin_buffer);   //NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
      |                                                     ^

Have any feedback or feature suggestions? Share it here.

Please sign in to comment.