http: simplify test and fix minor issues #210
Conversation
bennyz
commented
Jan 5, 2025
bennyz
commented
- simplify tests, and add a test for file retrieval
- remove unused loop param
- call shutdown before cleanup, as docs require
- simplify tests, and add a test for file retrieval - remove unused loop param - call shutdown before cleanup, as docs require Signed-off-by: Benny Zlotnik <[email protected]>
| files_after_deletion = client.list_files() | ||
| assert "test.txt" not in files_after_deletion | ||
| resource_uuid = uuid.uuid4() | ||
| server.resources[resource_uuid] = receive_stream |
There was a problem hiding this comment.
Hi, nice work,
Although I'd want us to consider if we still want to keep some test through the serve() / write_local_file method too.
The reason to propose it is that we otherwise stop testing the client slide at all, and all the inner interactions of client->exporter
There was a problem hiding this comment.
yeah, I figured I'd make it more similar to the tftp driver test and we can perhaps have a seperate test for the client, because in my initial attempt to do the HTTP GET in the context of serve didn't go well because of the mixed async/sync.
However, I will try again, perhaps it's simpler than it looks
There was a problem hiding this comment.
Let's do it the way you think makes more sense, I will leave the accepted to this PR, and we can follow up with some client tests, or include it here.
Thank @bennyz !
