Force kw_only for all config classes #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangelajo
reviewed
Jul 31, 2024
| @@ -56,7 +56,9 @@ def client_create( | |||
| if out is None and ClientConfig.exists(name): | |||
| raise click.ClickException(f"A client with the name '{name}' already exists.") | |||
|
|
|||
| config = ClientConfig(name, endpoint, token, drivers=ClientConfigDrivers(allow.split(","), unsafe)) | |||
| config = ClientConfig( | |||
| name=name, endpoint=endpoint, token=token, drivers=ClientConfigDrivers(allow=allow.split(","), unsafe=unsafe) | |||
There was a problem hiding this comment.
hehe in some others cases it's much better, in this case it makes the code too verbose. ':D
There was a problem hiding this comment.
Good news is that this is internal
mangelajo
reviewed
Jul 31, 2024
|
|
||
| def load_or_create() -> Self: | ||
| """Check if a user config exists, otherwise create an empty one.""" | ||
| if UserConfig.exists() is False: | ||
| if os.path.exists(UserConfig.BASE_CONFIG_PATH) is False: | ||
| os.makedirs(UserConfig.BASE_CONFIG_PATH) | ||
| config = UserConfig(None) | ||
| config = UserConfig(current_client=None) |
There was a problem hiding this comment.
I would keep it in cases like this, but without enforcing it may be. WDYT?
There was a problem hiding this comment.
Yeah, I'm just worried if we get more properties it'll get confusing.
mangelajo
reviewed
Jul 31, 2024
| ClientConfig, | ||
| "load", | ||
| return_value=ClientConfig( | ||
| name="testclient", endpoint="abc", token="123", drivers=ClientConfigDrivers(allow=[], unsafe=False) |
There was a problem hiding this comment.
I think this makes it look a lot more like the resulting YAML :D
mangelajo
approved these changes
Jul 31, 2024
| @@ -56,7 +56,9 @@ def client_create( | |||
| if out is None and ClientConfig.exists(name): | |||
| raise click.ClickException(f"A client with the name '{name}' already exists.") | |||
|
|
|||
| config = ClientConfig(name, endpoint, token, drivers=ClientConfigDrivers(allow.split(","), unsafe)) | |||
| config = ClientConfig( | |||
| name=name, endpoint=endpoint, token=token, drivers=ClientConfigDrivers(allow=allow.split(","), unsafe=unsafe) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve config code style to prevent confusion with different arguments.