Add support for MOI.BarrierIterations #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #389 +/- ##
==========================================
+ Coverage 94.02% 94.06% +0.04%
==========================================
Files 4 4
Lines 920 927 +7
==========================================
+ Hits 865 872 +7
Misses 55 55
☔ View full report in Codecov by Sentry. |
ojwoodford
reviewed
Oct 11, 2023
odow
commented
Oct 11, 2023
odow
commented
Oct 11, 2023
odow
commented
Oct 11, 2023
odow
commented
Oct 11, 2023
| model.barrier_iterations = 0 | ||
| function _moi_callback(args...) | ||
| # iter_count is args[2] | ||
| model.barrier_iterations = args[2] |
There was a problem hiding this comment.
Docs say that this method is called exactly once per iteration during convergence, so I guess it is save to do this:
https://coin-or.github.io/Ipopt/classIpopt_1_1TNLP.html#a2f962a4c43464adb7928771af84503d6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #388