Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix extra keyword args #174

Merged
merged 2 commits into from
Nov 27, 2024
Merged

fix: Fix extra keyword args #174

merged 2 commits into from
Nov 27, 2024

Conversation

whiterabbit1983
Copy link
Contributor

@whiterabbit1983 whiterabbit1983 commented Nov 25, 2024

Important

Refactor extra_kwargs extraction in patched_method to use dictionary comprehension for filtering extra keyword arguments.

  • Behavior:
    • Refactor extra_kwargs extraction in patched_method to use dictionary comprehension for filtering extra keyword arguments.
  • Functions:
    • patched_method in __init__.py now uses {k: v for k, v in kwargs.items() if k not in allowed_kwargs and k not in params} to determine extra_kwargs.

This description was created by Ellipsis for 9f7f28d. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 9f7f28d in 12 seconds

More details
  • Looked at 17 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. src/julep/lib/__init__.py:38
  • Draft comment:
    The new dictionary comprehension for extra_kwargs is more concise and efficient. Ensure that allowed_kwargs and params are correctly defined to avoid misclassifying necessary arguments as extra.
  • Reason this comment was not posted:
    Confidence changes required: 33%
    The change in the PR modifies how extra keyword arguments are extracted. The new implementation uses a dictionary comprehension, which is more concise and efficient. However, it's important to ensure that the logic remains correct and that no necessary arguments are mistakenly classified as extra.

Workflow ID: wflow_oXtxRhMZP3CVUkmf


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@creatorrr creatorrr merged commit ae1af39 into main Nov 27, 2024
3 checks passed
@creatorrr creatorrr deleted the x/fix-subworkflows branch November 27, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants