-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Patch instructions and canonical name #1057
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 2a393e3 in 11 seconds
More details
- Looked at
28
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. agents-api/agents_api/queries/agents/patch_agent.py:83
- Draft comment:
Ensuredata.instructions
is consistently a list before passing it to the SQL query. Consider handling cases wheredata.instructions
might beNone
or another type. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_OivbCQQPxVZEPF8e
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
2a393e3
to
0aa9621
Compare
CI Failure Feedback 🧐(Checks updated until commit 0aa9621)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 0aa9621 in 10 seconds
More details
- Looked at
13
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. agents-api/agents_api/queries/agents/patch_agent.py:83
- Draft comment:
Ensuredata.instructions
is notNone
before converting it to a list. This prevents passing[None]
wheninstructions
isNone
. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_I4T2znBq9s9SoO3l
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
PR Type
Bug fix, Enhancement
Description
Added support for patching
instructions
andcanonical_name
in thepatch_agent
query.Enhanced SQL query to handle new fields conditionally.
Updated function to process and pass new fields correctly.
Changes walkthrough 📝
patch_agent.py
Support patching instructions and canonical name
agents-api/agents_api/queries/agents/patch_agent.py
instructions
andcanonical_name
in SQLquery.
instructions
as a list or string.Important
Enhance
patch_agent
to support patchinginstructions
andcanonical_name
with updated SQL handling.patch_agent.py
:instructions
andcanonical_name
in thepatch_agent
function.instructions
as a list or string andcanonical_name
.instructions
andcanonical_name
.This description was created by for 0aa9621. It will automatically update as commits are pushed.