unify parse_storage_constraint or client.Constraints during deploy #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
addyess
force-pushed
the
issues/1075/storage-constraint-on-deploy
branch
from
f931900
to
183979a
Compare
addyess
force-pushed
the
issues/1075/storage-constraint-on-deploy
branch
2 times, most recently
from
0d08092
to
3c4bded
Compare
…ng deploy Signed-off-by: Adam Dyess <[email protected]>
addyess
force-pushed
the
issues/1075/storage-constraint-on-deploy
branch
from
3c4bded
to
3eb4cd3
Compare
|
@cderici do you think this is a PR that could be reviewed? |
|
This PR needs to be rebased since #1186 has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1075 by collapsing both storage constraint deviations in
model._deployQA Steps
All CI tests need to pass.
Notes & Discussion
Perhaps it's not the best change, feel free to scrap and adjust better.