cache: fix buffer conflict in writeback mode #5563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5563 +/- ##
===========================================
- Coverage 50.57% 21.49% -29.09%
===========================================
Files 166 29 -137
Lines 48152 19167 -28985
===========================================
- Hits 24353 4119 -20234
+ Misses 21076 14558 -6518
+ Partials 2723 490 -2233 ☔ View full report in Codecov by Sentry. |
jiefenghuang
changed the title
|
Currently, WithTimeout does not interrupt the goroutine after a timeout. It is necessary to set an appropriate default value for MaxStageWrite to prevent excessive concurrency under high load or abnormal conditions. |
polyrabbit
force-pushed
the
buffer-race
branch
from
9ddcf24 to
c3c55fa
Compare
|
Updated |
Signed-off-by: Changxin Miao <[email protected]>
polyrabbit
force-pushed
the
buffer-race
branch
from
c3c55fa to
eb97f2d
Compare
jiefenghuang
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug introduced in #5230
Otherwise, data corruption may happen.
