perf release mutex while waiting for retry #5499
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All other time.Sleep are all out of mutex scope. |
|
The reason we have sleep here is to reduce the concurrency of transactions, it will be useless if it unlocks the mutex. |
|
We have 1024 mutex here, if all are active, still too high concurrency for the backend database, so I feel is not used to limit the overall transaction concurrency. It's used to limit the transaction concurrency of single file or directory, as it is usually processed serially in backend. By the way, for sql engine there are backend solution for high concurrency control, such as thread pool or proxy etc. |
|
#5512 limit the maximum connections is another good way to control the transaction concurrency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the mutex scope for txn of redis/sql/tikv meta engine