Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/gc: fix delete slice #5451

Merged
merged 1 commit into from
Dec 27, 2024
Merged

cmd/gc: fix delete slice #5451

merged 1 commit into from
Dec 27, 2024

Conversation

jiefenghuang
Copy link
Contributor

@jiefenghuang jiefenghuang commented Dec 27, 2024

close #5445

Remove concurrency of OnMsg since MaxDeletes concurrency has been set.

Additionally, the asynchronous processing in OnMsg (meta.DeleteSlice) may lead to object storage leaks if the GC process is interrupted.

Signed-off-by: jiefenghuang <[email protected]>
@davies davies merged commit ad57d70 into main Dec 27, 2024
36 of 40 checks passed
@davies davies deleted the fix-gc branch December 27, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: send on closed channel on gc.
3 participants