Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: pass more environment variables to the cluster #5422

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Conversation

zhijian-pro
Copy link
Contributor

@zhijian-pro zhijian-pro commented Dec 23, 2024

close #5419

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 32.86%. Comparing base (654b316) to head (fe61c60).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
pkg/sync/config.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5422       +/-   ##
===========================================
- Coverage   50.62%   32.86%   -17.76%     
===========================================
  Files         166      133       -33     
  Lines       47542    38437     -9105     
===========================================
- Hits        24068    12634    -11434     
- Misses      20777    24548     +3771     
+ Partials     2697     1255     -1442     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhijian-pro zhijian-pro marked this pull request as draft December 23, 2024 11:19
@zhijian-pro zhijian-pro marked this pull request as ready for review December 23, 2024 11:21
@davies davies merged commit 8848390 into main Dec 23, 2024
39 checks passed
@davies davies deleted the pass-more-env branch December 23, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KEYTAB related environment variables are not passed to worker when sync.
2 participants