Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: remove tmp test bucket path before test #4157

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

eryugey
Copy link
Contributor

@eryugey eryugey commented Nov 10, 2023

To avoid test failure from the second run, as the test bucket path is not empty, i.e.

: Storage file:///tmp/testBucket/test/ is not empty; please clean it up or pick another volume name

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5163180) 46.34% compared to head (c8db7db) 55.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4157      +/-   ##
==========================================
+ Coverage   46.34%   55.51%   +9.17%     
==========================================
  Files         152      153       +1     
  Lines       38664    38906     +242     
==========================================
+ Hits        17917    21600    +3683     
+ Misses      18563    14888    -3675     
- Partials     2184     2418     +234     

see 52 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

To avoid test failure from the second run, as the test dir is not empty, e.g.

<FATAL>: Storage file:///tmp/testBucket/test/ is not empty; please clean it up or pick another volume name

Signed-off-by: Eryu Guan <[email protected]>
@davies davies merged commit 7ad455a into juicedata:main Nov 13, 2023
33 of 40 checks passed
@eryugey eryugey deleted the dev branch November 14, 2023 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants