Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the gateway to support more complete functionality #4030

Merged
merged 23 commits into from
Nov 21, 2023
Merged

Conversation

zhijian-pro
Copy link
Contributor

@zhijian-pro zhijian-pro commented Aug 31, 2023

Use juicefs as an implementation of minio's ObjectLayer, running it as a minio server rather than a minio gateway pattern

close #3537 #3375 #3107

depend on juicedata/minio#47

@zhijian-pro zhijian-pro added this to the Release 1.2 milestone Aug 31, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 105 lines in your changes are missing coverage. Please review.

Comparison is base (f38036c) 55.53% compared to head (7280d6a) 55.96%.
Report is 16 commits behind head on main.

Files Patch % Lines
pkg/gateway/gateway.go 38.88% 88 Missing and 11 partials ⚠️
cmd/gateway.go 77.77% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4030      +/-   ##
==========================================
+ Coverage   55.53%   55.96%   +0.42%     
==========================================
  Files         153      152       -1     
  Lines       38902    39049     +147     
==========================================
+ Hits        21606    21854     +248     
+ Misses      14876    14738     -138     
- Partials     2420     2457      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhijian-pro zhijian-pro marked this pull request as ready for review November 9, 2023 01:37
pkg/gateway/gateway.go Outdated Show resolved Hide resolved
pkg/gateway/gateway.go Outdated Show resolved Hide resolved
pkg/gateway/gateway.go Outdated Show resolved Hide resolved
pkg/gateway/gateway.go Outdated Show resolved Hide resolved
@zhijian-pro zhijian-pro marked this pull request as draft November 16, 2023 09:00
@zhijian-pro zhijian-pro marked this pull request as ready for review November 17, 2023 01:55
@davies davies merged commit 0e2c8a3 into main Nov 21, 2023
35 of 38 checks passed
@davies davies deleted the upgrade-gateway branch November 21, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement event notification in s3gateway
2 participants