fix: skip list dirs with no permissions

juicedata · Oct 26, 2023 · aee3deb · aee3deb
1 parent 606afbd
commit aee3deb
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/pkg/object/file.go b/pkg/object/file.go
@@ -338,6 +338,10 @@ func (d *filestore) ListAll(prefix, marker string) (<-chan Object, error) {
 			}
 
 			if err != nil {
+				if os.IsPermission(err) {
+					logger.Warnf("skip %s: %s", path, err)
+					return nil
+				}
 				if os.IsNotExist(err) {
 					logger.Warnf("skip not exist file or directory: %s", path)
 					return nil

diff --git a/pkg/object/hdfs.go b/pkg/object/hdfs.go
@@ -233,6 +233,10 @@ func (h *hdfsclient) ListAll(prefix, marker string) (<-chan Object, error) {
 	go func() {
 		_ = h.walk(root, func(path string, info os.FileInfo, err error) error {
 			if err != nil {
+				if os.IsPermission(err) {
+					logger.Warnf("skip %s: %s", path, err)
+					return filepath.SkipDir
+				}
 				if err == io.EOF {
 					err = nil // ignore
 				} else {

diff --git a/pkg/object/webdav.go b/pkg/object/webdav.go
@@ -240,6 +240,10 @@ func (w *webdav) ListAll(prefix, marker string) (<-chan Object, error) {
 		defer close(listed)
 		_ = w.Walk(root, func(path string, info fs.FileInfo, err error) error {
 			if err != nil {
+				if gowebdav.IsErrCode(err, http.StatusForbidden) {
+					logger.Warnf("skip %s: %s", path, err)
+					return nil
+				}
 				if gowebdav.IsErrNotFound(err) {
 					logger.Warnf("skip not exist file or directory: %s", path)
 					return nil