meta: add warning for binary dump from Redis and databases

juicedata · Dec 29, 2024 · 6fa7893 · 6fa7893
1 parent 2e734c9
commit 6fa7893
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/pkg/meta/redis_bak.go b/pkg/meta/redis_bak.go
@@ -78,6 +78,7 @@ func (m *redisMeta) dumpCounters(ctx Context, opt *DumpOption, ch chan<- *dumped
 }
 
 func (m *redisMeta) dumpMix(ctx Context, opt *DumpOption, ch chan<- *dumpedResult) error {
+	logger.Warnf("please make sure the redis server is readonly, otherwise the dumped metadata will be inconsistent")
 	pools := map[int][]*sync.Pool{
 		segTypeNode:    {{New: func() interface{} { return &pb.Node{} }}},
 		segTypeEdge:    {{New: func() interface{} { return &pb.Edge{} }}},

diff --git a/pkg/meta/sql_bak.go b/pkg/meta/sql_bak.go
@@ -77,6 +77,9 @@ func (m *dbMeta) dump(ctx Context, opt *DumpOption, ch chan<- *dumpedResult) err
 		}
 		defer sess.Rollback() //nolint:errcheck
 		ctx.WithValue(txSessionKey{}, sess)
+	} else {
+		logger.Warnf("dump database with %d threads, please make sure that it's readonly, "+
+			"otherwise the dumped metadata will be inconsistent", opt.Threads)
 	}
 	for _, f := range dumps {
 		err := f(ctx, opt, ch)