Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): fix up line highlight width in source view #846

Merged
merged 3 commits into from
Nov 24, 2024

Conversation

gioboa
Copy link
Contributor

@gioboa gioboa commented Nov 22, 2024

Fixes #31

The width of the line highlight takes up the entire content

image

@crowlKats
Copy link
Collaborator

not great that it doesnt span the entire width, as this causes a bit weird highlighting:

Screen.Recording.2024-11-22.at.16.07.41.mov

@gioboa
Copy link
Contributor Author

gioboa commented Nov 22, 2024

I see, let me check

@gioboa
Copy link
Contributor Author

gioboa commented Nov 23, 2024

I improved the highlight width behavior

fix-31.webm

Copy link
Collaborator

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@crowlKats crowlKats changed the title fix: fix up line highlight width fix(frontend): fix up line highlight width in source view Nov 24, 2024
@crowlKats crowlKats added this pull request to the merge queue Nov 24, 2024
Merged via the queue into jsr-io:main with commit e95b873 Nov 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Line highlight doesn't extend full width on mobile
2 participants