Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ban cjs and cts file extensions #818

Merged
merged 14 commits into from
Jan 15, 2025
Merged

fix: ban cjs and cts file extensions #818

merged 14 commits into from
Jan 15, 2025

Conversation

mbhrznr
Copy link
Contributor

@mbhrznr mbhrznr commented Nov 6, 2024

closes #713.

mbhrznr
mbhrznr commented Nov 6, 2024
View reviewed changes
api/src/analysis.rs Show resolved Hide resolved
api/src/gcp.rs Show resolved Hide resolved
lucacasonato
lucacasonato reviewed Nov 7, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a sentence about this in the relevant section in frontend/docs/troubleshooting.md?

api/src/tarball.rs Outdated Show resolved Hide resolved
api/src/tarball.rs Outdated Show resolved Hide resolved
@mbhrznr mbhrznr requested a review from lucacasonato November 8, 2024 17:39
@lucacasonato
Copy link
Member

Why did you remove the e2e test? I thought that was good 👍

@mbhrznr
Copy link
Contributor Author

mbhrznr commented Nov 8, 2024 •
edited
Loading

Why did you remove the e2e test? I thought that was good 👍

the e2e test was only successful due to the path.ends_with check and would now throw a graphError returned by deno_graph.
would it still make sense to have that one in place, wdyt?

edit: nvm, after the most recent update the expected commonJs error is returned.

lucacasonato
lucacasonato approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lucacasonato lucacasonato added this pull request to the merge queue Jan 15, 2025
Merged via the queue into jsr-io:main with commit d880926 Jan 15, 2025
6 checks passed
@mbhrznr mbhrznr deleted the fix/ban-cjs-and-cts branch January 15, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ban cjs & cts file extensions
2 participants
@mbhrznr @lucacasonato