First crack at mobile-friendly subnav #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donjo
approved these changes
Feb 28, 2024
lucacasonato
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting all the nav items into a hamburger menu is quite a bit of work with the current implementation, and I'm not entirely sure it's a better user experience than seeing all the options anyway.
The main issue seemed to be how much space the menu was taking up, so this seems like, if nothing else, a reasonable low-lift stopgap, even if we rework it later.
It makes the nav always tabs, and lets them wrap onto multiple rows when there's not enough room for all of them. We could do horizontal scroll, like we do now on md+ screens, but if we go that route I'd want to invest in making the horizontal scroll very clear.